From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Flavia Musatescu <flavia.musatescu@intel.com>,
dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Cc: stable@dpdk.org, shahafs@mellanox.com
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: remove duplicated support for Rx offloading
Date: Tue, 27 Aug 2019 09:48:20 +0100 [thread overview]
Message-ID: <d8418d1f-0dd2-0907-5603-81d2dd2ad82c@intel.com> (raw)
In-Reply-To: <1565007903-13910-1-git-send-email-flavia.musatescu@intel.com>
On 8/5/2019 1:25 PM, Flavia Musatescu wrote:
> The testpmd application provides two sets of commands for RX offload
> flags configuration. The purpose of this patch is to eliminate this
> duplication by removing the old set of commands:
> “port config all crc-strip|scatter|rx-cksum|rx-timestamp|hw-vlan|
> hw-vlan-filter|hw-vlan-strip|hw-vlan-extend on|off”
>
> The other commands set that can be used instead in order to enable
> or disable the same RX offloading flags on all RX queues of a port is:
> "port config <port_id> rx_offload crc_strip|scatter|ipv4_cksum|
> udp_cksum|tcp_cksum|timestamp|vlan_strip|vlan_filter|vlan_extend on|off"
>
> This patch also fixes the "drop-en" command, which enables packets
> dropping on all RX queues of all ports when no receive buffers available
> “port config all drop-en on|off”
>
> Fixes: 384161e00627 ("app/testpmd: adjust on the fly VLAN configuration")
> Cc: shahafs@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Flavia Musatescu <flavia.musatescu@intel.com>
> ---
> app/test-pmd/cmdline.c | 120 ++++------------------------
> doc/guides/rel_notes/release_19_08.rst | 9 +++
Hi Flavia,
Can you please send a new version with the 19.11 release notes update?
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 81 +------------------
> 3 files changed, 25 insertions(+), 185 deletions(-)
<...>
next prev parent reply other threads:[~2019-08-27 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 12:25 Flavia Musatescu
2019-08-27 8:48 ` Ferruh Yigit [this message]
2019-08-27 16:43 ` [dpdk-stable] [PATCH v2] " Flavia Musatescu
2019-08-28 9:29 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8418d1f-0dd2-0907-5603-81d2dd2ad82c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=flavia.musatescu@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).