From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CBEE92BE1; Tue, 17 Jul 2018 16:33:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2018 07:33:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,365,1526367600"; d="scan'208";a="67625892" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.102]) ([10.237.220.102]) by orsmga003.jf.intel.com with ESMTP; 17 Jul 2018 07:33:50 -0700 To: Reshma Pattan , thomas@monjalon.net, dev@dpdk.org Cc: jananeex.m.parthasarathy@intel.com, stable@dpdk.org References: <1531833331-18148-1-git-send-email-reshma.pattan@intel.com> <1531833331-18148-10-git-send-email-reshma.pattan@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Tue, 17 Jul 2018 15:33:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1531833331-18148-10-git-send-email-reshma.pattan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v4 9/9] mk: update make targets for classified testcases X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 14:33:53 -0000 On 17-Jul-18 2:15 PM, Reshma Pattan wrote: > Makefiles are updated with new test case lists. > Test cases are classified as - > P1 - Main test cases, > P2 - Cryptodev/driver test cases, > P3 - Perf test cases which takes longer than 10s, > P4 - Logging/Dump test cases. > > Makefile is updated with different targets > for the above classified groups. > Test cases for different targets are listed accordingly. > > Cc: stable@dpdk.org > > Signed-off-by: Jananee Parthasarathy > Reviewed-by: Reshma Pattan > --- > mk/rte.sdkroot.mk | 4 ++-- > mk/rte.sdktest.mk | 33 +++++++++++++++++++++++++++------ > 2 files changed, 29 insertions(+), 8 deletions(-) > > diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk > index f43cc7829..ea3473ebf 100644 > --- a/mk/rte.sdkroot.mk > +++ b/mk/rte.sdkroot.mk > @@ -68,8 +68,8 @@ config defconfig showconfigs showversion showversionum: > cscope gtags tags etags: > $(Q)$(RTE_SDK)/devtools/build-tags.sh $@ $T > > -.PHONY: test test-basic test-fast test-ring test-mempool test-perf coverage > -test test-basic test-fast test-ring test-mempool test-perf coverage: > +.PHONY: test test-basic test-fast test-ring test-mempool test-perf coverage test-drivers test-dump > +test test-basic test-fast test-ring test-mempool test-perf coverage test-drivers test-dump: I'm probably missing something, but i can only see definitions for coverage, test-fast, test-perf, test-drivers and test-dump. What is the difference between test and test-basic, and what is test-mempool? If they are unused, they should be removed. > $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@ > > test: test-build > diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk > index ee1fe0c7e..13d1efb6a 100644 > --- a/mk/rte.sdktest.mk > +++ b/mk/rte.sdktest.mk > @@ -18,14 +18,35 @@ DIR := $(shell basename $(RTE_OUTPUT)) > # > # test: launch auto-tests, very simple for now. > # > -.PHONY: test test-basic test-fast test-perf coverage > +.PHONY: test test-basic test-fast test-perf test-drivers test-dump coverage > > -PERFLIST=ring_perf,mempool_perf,memcpy_perf,hash_perf,timer_perf > -coverage: BLACKLIST=-$(PERFLIST) > -test-fast: BLACKLIST=-$(PERFLIST) > -test-perf: WHITELIST=$(PERFLIST) > +PERFLIST=ring_perf,mempool_perf,memcpy_perf,hash_perf,timer_perf,\ > + reciprocal_division,reciprocal_division_perf,lpm_perf,red_all,\ > + barrier,hash_multiwriter,timer_racecond,efd,hash_functions,\ > + eventdev_selftest_sw,member_perf,efd_perf,lpm6_perf,red_perf,\ > + distributor_perf,ring_pmd_perf,pmd_perf,ring_perf > +DRIVERSLIST=link_bonding,link_bonding_mode4,link_bonding_rssconf,\ > + cryptodev_sw_mrvl,cryptodev_dpaa2_sec,cryptodev_dpaa_sec,\ > + cryptodev_qat,cryptodev_aesni_mb,cryptodev_openssl,\ > + cryptodev_scheduler,cryptodev_aesni_gcm,cryptodev_null,\ > + cryptodev_sw_snow3g,cryptodev_sw_kasumi,cryptodev_sw_zuc > +DUMPLIST=dump_struct_sizes,dump_mempool,dump_malloc_stats,dump_devargs,\ > + dump_log_types,dump_ring,quit,dump_physmem,dump_memzone,\ > + devargs_autotest > > -test test-basic test-fast test-perf: > +SPACESTR:= > +SPACESTR+= > +STRIPPED_PERFLIST=$(subst $(SPACESTR),,$(PERFLIST)) > +STRIPPED_DRIVERSLIST=$(subst $(SPACESTR),,$(DRIVERSLIST)) > +STRIPPED_DUMPLIST=$(subst $(SPACESTR),,$(DUMPLIST)) > + > +coverage: BLACKLIST=-$(STRIPPED_PERFLIST) > +test-fast: BLACKLIST=-$(STRIPPED_PERFLIST),$(STRIPPED_DRIVERSLIST),$(STRIPPED_DUMPLIST) > +test-perf: WHITELIST=$(STRIPPED_PERFLIST) > +test-drivers: WHITELIST=$(STRIPPED_DRIVERSLIST) > +test-dump: WHITELIST=$(STRIPPED_DUMPLIST) > + > +test test-basic test-fast test-perf test-drivers test-dump: > @mkdir -p $(AUTOTEST_DIR) ; \ > cd $(AUTOTEST_DIR) ; \ > if [ -f $(RTE_OUTPUT)/app/test ]; then \ > -- Thanks, Anatoly