From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D507E1B552; Wed, 11 Jul 2018 14:24:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 05:24:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,338,1526367600"; d="scan'208";a="239495927" Received: from istokes-mobl1.ger.corp.intel.com (HELO [10.252.0.32]) ([10.252.0.32]) by orsmga005.jf.intel.com with ESMTP; 11 Jul 2018 05:24:51 -0700 To: "Lu, Wenzhuo" , "dev@dpdk.org" Cc: "stable@dpdk.org" References: <1530280253-10370-1-git-send-email-ian.stokes@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B8027C1@shsmsx102.ccr.corp.intel.com> From: Ian Stokes Message-ID: Date: Wed, 11 Jul 2018 13:24:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B8027C1@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/e1000: Support mtu set for igbvf. X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 12:24:58 -0000 On 7/10/2018 2:03 AM, Lu, Wenzhuo wrote: > Hi Ian, > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ian Stokes >> Sent: Friday, June 29, 2018 9:51 PM >> To: dev@dpdk.org >> Cc: Stokes, Ian ; stable@dpdk.org >> Subject: [dpdk-dev] [PATCH v2] net/e1000: Support mtu set for igbvf. >> >> This patch enables setting the MTU of an igbvf device by re-using the >> eth_igb_mtu_set() in igbvf_eth_dev_ops. >> >> Cc: stable@dpdk.org >> >> Signed-off-by: Ian Stokes >> --- >> drivers/net/e1000/igb_ethdev.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c >> index edc7be3..650e831 100644 >> --- a/drivers/net/e1000/igb_ethdev.c >> +++ b/drivers/net/e1000/igb_ethdev.c >> @@ -442,6 +442,7 @@ static const struct eth_dev_ops igbvf_eth_dev_ops = >> { >> .txq_info_get = igb_txq_info_get, >> .mac_addr_set = igbvf_default_mac_addr_set, >> .get_reg = igbvf_get_regs, >> + .mtu_set = eth_igb_mtu_set, > I think "eth_igb_mtu_set" is PF specific function that cannot be used on VF. As it touches PF specific registers. > Looks like MTU setting even not supported by igb VF. > Thanks for the feedback, I'm surprised it's not supported, is there documentation somewhere for this? I have tested this patch for an IGB SRIOV device and it worked without issue as far as I could tell, I was able to set the MTU for the igb vf, packets less than or equal to the mtu were passed, packets above the mtu were dropped as expected. Packets that were passed were not corrupted. I've tested this with OVS DPDK. I've spotted that a few of the class functions for the igbvf eth ops use eth_igb functions, is it the case that some features are supported for both devices? (I had assumed this albeit maybe incorrectly). Ian