From: Radu Nicolau <radu.nicolau@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>
Subject: Re: [PATCH] eal/x86: fix 32-bit write-combined stores
Date: Fri, 6 Sep 2024 16:18:13 +0100 [thread overview]
Message-ID: <db805fc2-9c59-4a4c-8c38-9b3e54df2ee8@intel.com> (raw)
In-Reply-To: <20240906132757.457921-1-bruce.richardson@intel.com>
On 06-Sep-24 2:27 PM, Bruce Richardson wrote:
> The "movdiri" instruction is given as a series of bytes in rte_io.h so
> that it works on compilers/assemblers which are unaware of the
> instruction. The REX prefix (0x40) on this instruction is invalid for
> 32-bit code, causing issues. Thankfully, the prefix is unnecessary in
> 64-bit code, since the data size used is 32-bits.
>
> Fixes: 8a00dfc738fe ("eal: add write combining store")
> Cc: radu.nicolau@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
next prev parent reply other threads:[~2024-09-06 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 13:27 Bruce Richardson
2024-09-06 15:18 ` Radu Nicolau [this message]
2024-09-12 5:56 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db805fc2-9c59-4a4c-8c38-9b3e54df2ee8@intel.com \
--to=radu.nicolau@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).