* [dpdk-stable] [PATCH 01/18] net/bonding: fix link speed update in broadcast mode
[not found] <1568103959-25572-1-git-send-email-arybchenko@solarflare.com>
@ 2019-09-10 8:25 ` Andrew Rybchenko
2019-09-10 23:01 ` [dpdk-stable] [dpdk-dev] " Chas Williams
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Rybchenko @ 2019-09-10 8:25 UTC (permalink / raw)
To: Chas Williams; +Cc: dev, Igor Romanov, stable
From: Igor Romanov <igor.romanov@oktetlabs.ru>
Fix the issue that the link speed of the bond device was set to the
link speed of the first active slave in broadcast mode.
Set the link speed of the bond device to the minimum value across
all of the slaves in that case.
Fixes: deba8a2f8b0b ("net/bonding: fix link properties management")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index f774e5677..fed71bd95 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -2395,8 +2395,8 @@ bond_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete)
* packet loss will occur on this slave if transmission at rates
* greater than this are attempted
*/
- for (idx = 1; idx < bond_ctx->active_slave_count; idx++) {
- link_update(bond_ctx->active_slaves[0], &slave_link);
+ for (idx = 0; idx < bond_ctx->active_slave_count; idx++) {
+ link_update(bond_ctx->active_slaves[idx], &slave_link);
if (slave_link.link_speed <
ethdev->data->dev_link.link_speed)
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 01/18] net/bonding: fix link speed update in broadcast mode
2019-09-10 8:25 ` [dpdk-stable] [PATCH 01/18] net/bonding: fix link speed update in broadcast mode Andrew Rybchenko
@ 2019-09-10 23:01 ` Chas Williams
0 siblings, 0 replies; 2+ messages in thread
From: Chas Williams @ 2019-09-10 23:01 UTC (permalink / raw)
To: Andrew Rybchenko, Chas Williams; +Cc: dev, Igor Romanov, stable
Acked-by: Chas Williams <chas3@att.com>
On 9/10/19 4:25 AM, Andrew Rybchenko wrote:
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> Fix the issue that the link speed of the bond device was set to the
> link speed of the first active slave in broadcast mode.
>
> Set the link speed of the bond device to the minimum value across
> all of the slaves in that case.
>
> Fixes: deba8a2f8b0b ("net/bonding: fix link properties management")
> Cc: stable@dpdk.org
>
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index f774e5677..fed71bd95 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -2395,8 +2395,8 @@ bond_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete)
> * packet loss will occur on this slave if transmission at rates
> * greater than this are attempted
> */
> - for (idx = 1; idx < bond_ctx->active_slave_count; idx++) {
> - link_update(bond_ctx->active_slaves[0], &slave_link);
> + for (idx = 0; idx < bond_ctx->active_slave_count; idx++) {
> + link_update(bond_ctx->active_slaves[idx], &slave_link);
>
> if (slave_link.link_speed <
> ethdev->data->dev_link.link_speed)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-10 23:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1568103959-25572-1-git-send-email-arybchenko@solarflare.com>
2019-09-10 8:25 ` [dpdk-stable] [PATCH 01/18] net/bonding: fix link speed update in broadcast mode Andrew Rybchenko
2019-09-10 23:01 ` [dpdk-stable] [dpdk-dev] " Chas Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).