From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 943B2A0563 for ; Mon, 16 Mar 2020 11:16:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 795B41C065; Mon, 16 Mar 2020 11:16:02 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 5209E1C02A for ; Mon, 16 Mar 2020 11:15:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584353758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uAC/aK+kWpVvCHGVk4AtVwLWVkJo0HewhWZJhYhrfK4=; b=AtIZlf4Nhj79CJXI7GPGGGWF/6OB51ZhCoxhQDFMdiYGT7eLA0Kv4qpvUn1Vrg+D5hrYLY 0S0xuDIjINDwmuiNHZAOjLf1UJ91O3hLMnEIjwO8DJvS/Ee2hhpB2Ptv48lu8Uj8sT7tHT rTCAEwaMEpkyy4pETAU7amzAy+LV5II= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-93-dJNgRnj3NBC6HjZCt1qUIQ-1; Mon, 16 Mar 2020 06:15:55 -0400 X-MC-Unique: dJNgRnj3NBC6HjZCt1qUIQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B2E018A551E; Mon, 16 Mar 2020 10:15:53 +0000 (UTC) Received: from [10.33.36.200] (unknown [10.33.36.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 85D1F94C04; Mon, 16 Mar 2020 10:15:50 +0000 (UTC) To: "Li, Xiaoyun" , Zhike Wang , "dev@dpdk.org" Cc: "Xing, Beilei" , "Zhang, Qi Z" , "stable@dpdk.org" References: <1579137597-14076-1-git-send-email-wangzhike@jd.com> <36b37ce80e63461cbb6ec200abfeb38a@intel.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: Date: Mon, 16 Mar 2020 10:15:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <36b37ce80e63461cbb6ec200abfeb38a@intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix X722 judgement when disable adminq operation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 16/03/2020 02:02, Li, Xiaoyun wrote: >=20 >=20 >> -----Original Message----- >> From: Kevin Traynor [mailto:ktraynor@redhat.com] >> Sent: Saturday, March 14, 2020 03:16 >> To: Li, Xiaoyun ; Zhike Wang ; >> dev@dpdk.org >> Cc: Xing, Beilei ; Zhang, Qi Z ; >> stable@dpdk.org >> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix X722 judgeme= nt >> when disable adminq operation >> >> On 13/03/2020 04:40, Li, Xiaoyun wrote: >>> Hi >>> >>> This issue is already fixed in 20.02 with base code update of the follo= wing >> commit. >>> >>> >>> >>> commit 37b091c75b13d2f26359be9b77adbc33c55a7581 >>> >>> Author: Xiaolong Ye >>> >>> Date: Mon Jan 13 10:39:31 2020 +0800 >>> >>> >>> >>> net/i40e/base: extend PHY access AQ command >>> >>> >>> >>> Currently FW use MDIO I/F number corresponded with current PF for P= HY >>> >>> access. This code allow to specify used MDIO I/F number. >>> >>> >>> >>> Signed-off-by: Piotr Azarewicz >>> >>> Signed-off-by: Xiaolong Ye >>> >>> Acked-by: Qi Zhang >>> >>> Acked-by: Beilei Xing beilei.xing@intel.com >>> >>> >>> >>> But it makes sense to back port this to stable release so it can work w= ith dpdk >> version <=3D19.11. >>> >>> Still some comments inline. >>> >>> >>> >>>> -----Original Message----- >>> >>>> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Zhike Wang >>> >>>> Sent: Thursday, January 16, 2020 09:20 >>> >>>> To: dev@dpdk.org >>> >>>> Cc: Xing, Beilei ; Zhang, Qi Z ; >>> >>>> stable@dpdk.org; Zhike Wang >>> >>>> Subject: [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disab= le >>> >>>> adminq operation >>> >>>> >>> >>>> X722 SFPs have different flavors, eg I40E_DEV_ID_SFP_X722 >>> >>>> /I40E_DEV_ID_SFP_I_X722. So instead we use mac.type to judge whether i= t is >>> >>>> X722 or not. >>> >>>> >>> >>> Please be careful about your commit log. If you use mac.type =3D=3D X72= 2, then >> that's not just X722 SFP but all X722 devices. >>> >>> You can just say something like X722 doesn't support adminq operation s= o >> disable it. >>> >> >> You say commit log, but isn't that what is done in the code? >=20 > His commit log only says about X722 SFPs but mac.type =3D=3D X722 means a= ll X722 devices. SFPs are only a part of X722. > So I prefer his commit log can explain the root cause. >=20 Yes, my comment/question is similar about the code. "if (hw->mac.type =3D=3D I40E_MAC_X722)" is this correct? >> >>> >>> >>>> Fixes: 9efa8d28b ("net/i40e: fix SFP X722 with FW4.16") >>> >>> Please follow the DPDK community code style. Fix line needs commit id o= f 12 >> bit. >>> >>> In this case, should be: Fixes: 9efa8d28b4da ("net/i40e: fix SFP X722 w= ith >> FW4.16") >>> >>> And since this fix makes sense for <=3D19.11, please add this line: Cc: >> stable@dpdk.org >>> >> >> Please add the stable branches requested in the usual format. >> >> http://doc.dpdk.org/guides/contributing/patches.html#backporting-patches= - >> for-stable-releases >> >>> >>> >>>> Signed-off-by: Zhike Wang > >>> >>>> --- >>> >>>> drivers/net/i40e/i40e_ethdev.c | 2 +- >>> >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>>> >>> >>>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_et= hdev.c >>> >>>> index 5999c96..85ccb76 100644 >>> >>>> --- a/drivers/net/i40e/i40e_ethdev.c >>> >>>> +++ b/drivers/net/i40e/i40e_ethdev.c >>> >>>> @@ -1443,7 +1443,7 @@ static inline void i40e_config_automask(struct >>> >>>> i40e_pf *pf) >>> >>>> return -EIO; >>> >>>> } >>> >>>> /* Firmware of SFP x722 does not support adminq option */ >>> >>>> - if (hw->device_id =3D=3D I40E_DEV_ID_SFP_X722) >>> >>>> + if (hw->mac.type =3D=3D I40E_MAC_X722) >>> >>>> hw->flags &=3D ~I40E_HW_FLAG_802_1AD_CAPABL= E; >>> >>>> >>> >>>> PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d >>> >>>> eetrack %04x", >>> >>>> -- >>> >>>> 1.8.3.1 >>> >>>> >>> >=20