From: Kevin Traynor <ktraynor@redhat.com>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>, stable@dpdk.org
Cc: mohsinshaikh@niometrics.com
Subject: Re: [dpdk-stable] [PATCH v2] [18.11] net/mlx5: use open/read/close for ib stats query
Date: Tue, 8 Dec 2020 13:37:56 +0000 [thread overview]
Message-ID: <dc82fc72-c1c2-e1cc-bc98-d1339bf7f4bf@redhat.com> (raw)
In-Reply-To: <1607431544-2831-1-git-send-email-viacheslavo@nvidia.com>
On 08/12/2020 12:45, Viacheslav Ovsiienko wrote:
> From: Mohsin Shaikh <mohsinshaikh@niometrics.com>
>
> [ upstream commit 00437823cb80b8fa87dbe61becc07bd42ee98549 ]
>
> fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) which leads
> to TLB shutdown interrupts to all DPDK app cores including RX cores.
> This can cause packet drops. Use read(2)/write(2) instead.
>
> Bugzilla ID: 440
> Cc: stable@dpdk.org
>
> Signed-off-by: Mohsin Shaikh <mohsinshaikh@niometrics.com>
> Reviewed-by: Alexander Kozyrev <akozyrev@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_stats.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2020-12-08 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 12:45 Viacheslav Ovsiienko
2020-12-08 13:37 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc82fc72-c1c2-e1cc-bc98-d1339bf7f4bf@redhat.com \
--to=ktraynor@redhat.com \
--cc=mohsinshaikh@niometrics.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).