From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1BDFA09E8 for ; Tue, 8 Dec 2020 14:38:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A206CA3; Tue, 8 Dec 2020 14:38:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 1EB18A3 for ; Tue, 8 Dec 2020 14:38:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607434681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TLiaWQoVaFbyHAg9w+uqmC0DNwv3QQ1/3LpS6//2LSA=; b=LEgpEehyPLWWIClG/g6AEQCbRJ0Opgf2n/WzEGM7lq7KibZ7mXq0PEGUi7wGBVrIjnogDR 0RN+Ywo6IccsfIfxlGVTMQWBmV42emRktRlpz8G4nBwTztBariTov2k+L2EpIaSFL8I6Gn cmKBE/3HBGTv8x3k7Pu3d84V0ojRIJo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-CqFEn5XXOrSF5Gm7Fe08sw-1; Tue, 08 Dec 2020 08:37:59 -0500 X-MC-Unique: CqFEn5XXOrSF5Gm7Fe08sw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6319C520E; Tue, 8 Dec 2020 13:37:58 +0000 (UTC) Received: from [10.36.114.230] (ovpn-114-230.ams2.redhat.com [10.36.114.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9DF7B5D9DE; Tue, 8 Dec 2020 13:37:57 +0000 (UTC) To: Viacheslav Ovsiienko , stable@dpdk.org Cc: mohsinshaikh@niometrics.com References: <1607431544-2831-1-git-send-email-viacheslavo@nvidia.com> From: Kevin Traynor Message-ID: Date: Tue, 8 Dec 2020 13:37:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1607431544-2831-1-git-send-email-viacheslavo@nvidia.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [PATCH v2] [18.11] net/mlx5: use open/read/close for ib stats query X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 08/12/2020 12:45, Viacheslav Ovsiienko wrote: > From: Mohsin Shaikh > > [ upstream commit 00437823cb80b8fa87dbe61becc07bd42ee98549 ] > > fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) which leads > to TLB shutdown interrupts to all DPDK app cores including RX cores. > This can cause packet drops. Use read(2)/write(2) instead. > > Bugzilla ID: 440 > Cc: stable@dpdk.org > > Signed-off-by: Mohsin Shaikh > Reviewed-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_stats.c | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) Applied, thanks.