From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yang, MurphyX" <murphyx.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, MurphyX" <murphyx.yang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/iavf: fix link status
Date: Wed, 23 Sep 2020 23:27:50 +0000 [thread overview]
Message-ID: <dd4ed85f4a1d43fd9bcf65fd63696f22@intel.com> (raw)
In-Reply-To: <20200918094718.22621-1-murphyx.yang@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of murphy yang
> Sent: Friday, September 18, 2020 5:47 PM
> To: dev@dpdk.org
> Cc: Yang, MurphyX <murphyx.yang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/iavf: fix link status
>
> From: murphy <murphyx.yang@intel.com>
>
> If the PF driver supports the new speed reporting capabilities then use
> link_event_adv instead of link_event to get the speed.
>
> Fixes: 5330b042977c ("net/iavf: fix link speed")
>
> Cc: stable@dpdk.org
>
> Signed-off-by: murphy <murphyx.yang@intel.com>
> ---
> drivers/net/iavf/iavf_vchnl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index
> 76f8e38d1..c4956dc58 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -195,14 +195,13 @@ iavf_handle_pf_event_msg(struct rte_eth_dev *dev,
> uint8_t *msg,
> case VIRTCHNL_EVENT_LINK_CHANGE:
> PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_LINK_CHANGE event");
> vf->link_up = pf_msg->event_data.link_event.link_status;
> + enum virtchnl_link_speed speed;
> if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_ADV_LINK_SPEED)
> {
> - vf->link_speed =
> - pf_msg->event_data.link_event_adv.link_speed;
> + speed = pf_msg->event_data.link_event_adv.link_speed;
According to vritual channel spec, link_event_adv.link_speed should store the link_speed provided in Mbps, it no need to be further converted.
If the value is wrong, it should be fixed in kernel driver.
> } else {
> - enum virtchnl_link_speed speed;
> speed = pf_msg->event_data.link_event.link_speed;
> - vf->link_speed = iavf_convert_link_speed(speed);
> }
> + vf->link_speed = iavf_convert_link_speed(speed);
> iavf_dev_link_update(dev, 0);
> rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC,
> NULL);
> break;
> --
> 2.17.1
prev parent reply other threads:[~2020-09-23 23:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 9:47 [dpdk-stable] " murphy yang
2020-09-23 23:27 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd4ed85f4a1d43fd9bcf65fd63696f22@intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=murphyx.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).