From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AE1F4586B for ; Mon, 26 Aug 2024 12:26:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31404402A7; Mon, 26 Aug 2024 12:26:16 +0200 (CEST) Received: from smtp-fw-80009.amazon.com (smtp-fw-80009.amazon.com [99.78.197.220]) by mails.dpdk.org (Postfix) with ESMTP id 584EA40272 for ; Mon, 26 Aug 2024 12:26:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1724667974; x=1756203974; h=from:to:cc:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=xG68xmXyncsrBg9FTn+r3jwGoHdCOewOi5iuilgfkfU=; b=AJcHcBW0KMMSvynQ8JRkVCbpkmMqsQoYsmHpzrgHpmZDmD5ldDagqMmh 5dKAteogYEDiJ64eIOnTX37SgEXhTc6yKV2SheqPz1AFa6H/58ZfXI28d Z45kl+YdBrQN7bZVNNN82P1AwLd8pfVkY7syvPHBt2JWfsnupMoZmLiOg Y=; X-IronPort-AV: E=Sophos;i="6.10,177,1719878400"; d="scan'208";a="118935850" Subject: RE: patch 'net/ena: fix bad checksum handling' has been queued to stable release 21.11.8 Thread-Topic: patch 'net/ena: fix bad checksum handling' has been queued to stable release 21.11.8 Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.25.36.210]) by smtp-border-fw-80009.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2024 10:26:11 +0000 Received: from EX19MTAEUB002.ant.amazon.com [10.0.43.254:37000] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.33.212:2525] with esmtp (Farcaster) id 73e19c69-1980-4060-b115-62f20757e93a; Mon, 26 Aug 2024 10:26:10 +0000 (UTC) X-Farcaster-Flow-ID: 73e19c69-1980-4060-b115-62f20757e93a Received: from EX19D007EUA002.ant.amazon.com (10.252.50.68) by EX19MTAEUB002.ant.amazon.com (10.252.51.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Mon, 26 Aug 2024 10:26:09 +0000 Received: from EX19D007EUA002.ant.amazon.com (10.252.50.68) by EX19D007EUA002.ant.amazon.com (10.252.50.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.35; Mon, 26 Aug 2024 10:26:08 +0000 Received: from EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc]) by EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc%3]) with mapi id 15.02.1258.035; Mon, 26 Aug 2024 10:26:08 +0000 From: "Brandes, Shai" To: Kevin Traynor CC: dpdk stable , "Brandes, Shai" Thread-Index: AQHa9XjRhHpNe7XTwE6MZq2dVAVTY7I5QMBQ Date: Mon, 26 Aug 2024 10:26:08 +0000 Message-ID: References: <20240823161929.1004778-1-ktraynor@redhat.com> <20240823161929.1004778-109-ktraynor@redhat.com> In-Reply-To: <20240823161929.1004778-109-ktraynor@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.213.30] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Kevin,=20 I think there is one net/ena patch that was not picked up for the stable re= lease (likely since there are two patches with similar title). I would appreciate if you could verify. The missing patch: net/ena: fix wrong handling of checksum see patchwork https://patches.dpdk.org/project/dpdk/patch/20240702144626.14= 545-14-shaibran@amazon.com/ All the best, Shai Brandes ENA drivers team > -----Original Message----- > From: Kevin Traynor > Sent: Friday, August 23, 2024 7:19 PM > To: Brandes, Shai > Cc: dpdk stable > Subject: [EXTERNAL] patch 'net/ena: fix bad checksum handling' has been > queued to stable release 21.11.8 >=20 > CAUTION: This email originated from outside of the organization. Do not c= lick > links or open attachments unless you can confirm the sender and know the > content is safe. >=20 >=20 >=20 > Hi, >=20 > FYI, your patch has been queued to stable release 21.11.8 >=20 > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 08/28/24. So please shout= if > anyone has objections. >=20 > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. >=20 > Queued patches are on a temporary branch at: > https://github.com/kevintraynor/dpdk-stable >=20 > This queued commit can be viewed at: > https://github.com/kevintraynor/dpdk- > stable/commit/082bd6be7b93ae090f2bdcc55fddc48c3bf16c2f >=20 > Thanks. >=20 > Kevin >=20 > --- > From 082bd6be7b93ae090f2bdcc55fddc48c3bf16c2f Mon Sep 17 00:00:00 > 2001 > From: Shai Brandes > Date: Tue, 2 Jul 2024 17:46:22 +0300 > Subject: [PATCH] net/ena: fix bad checksum handling >=20 > [ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ] >=20 > Removed a workaround for a false L4 bad Rx csum indication from the > device. The workaround was to set it as unknown so the application would > check it instead. > The issue was fixed in the device, thus the driver bad csum handling shou= ld > be fixed in the PMD. >=20 > Fixes: b2d2f1cf89a6 ("net/ena: fix checksum flag for L4") >=20 > Signed-off-by: Shai Brandes > --- > drivers/net/ena/ena_ethdev.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) >=20 > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 1c61f793e6..84c41f1b9d 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -311,11 +311,5 @@ static inline void ena_rx_mbuf_prepare(struct > rte_mbuf *mbuf, > else > if (unlikely(ena_rx_ctx->l4_csum_err)) > - /* > - * For the L4 Rx checksum offload the HW may indi= cate > - * bad checksum although it's valid. Because of t= hat, > - * we're setting the UNKNOWN flag to let the app > - * re-verify the checksum. > - */ > - ol_flags |=3D RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN; > + ol_flags |=3D RTE_MBUF_F_RX_L4_CKSUM_BAD; > else > ol_flags |=3D RTE_MBUF_F_RX_L4_CKSUM_GOOD; > -- > 2.46.0 >=20 > --- > Diff of the applied patch vs upstream commit (please double-check if no= n- > empty: > --- > --- - 2024-08-23 17:18:12.913173354 +0100 > +++ 0109-net-ena-fix-bad-checksum-handling.patch 2024-08-23 > 17:18:09.849430556 +0100 > @@ -1 +1 @@ > -From fa4bb7025255036fcff9556c637efa2627ac4af4 Mon Sep 17 00:00:00 2001 > +From 082bd6be7b93ae090f2bdcc55fddc48c3bf16c2f Mon Sep 17 00:00:00 > 2001 > @@ -5,0 +6,2 @@ > +[ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ] > + > @@ -13 +14,0 @@ > -Cc: stable@dpdk.org > @@ -21 +22 @@ > -index 4e7171e629..b43b913903 100644 > +index 1c61f793e6..84c41f1b9d 100644 > @@ -24,3 +25,3 @@ > -@@ -675,11 +675,5 @@ static inline void ena_rx_mbuf_prepare(struct > ena_ring *rx_ring, > - if (unlikely(ena_rx_ctx->l4_csum_err)) { > - ++rx_stats->l4_csum_bad; > +@@ -311,11 +311,5 @@ static inline void ena_rx_mbuf_prepare(struct > rte_mbuf *mbuf, > + else > + if (unlikely(ena_rx_ctx->l4_csum_err)) > @@ -35,2 +36,2 @@ > - } else { > - ++rx_stats->l4_csum_good; > + else > + ol_flags |=3D RTE_MBUF_F_RX_L4_CKSUM_GOOD;