From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79202A0540 for ; Tue, 13 Dec 2022 09:18:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 597D34021D; Tue, 13 Dec 2022 09:18:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7DD2240146 for ; Tue, 13 Dec 2022 09:17:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670919478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mRU6VEvqfVDeW6ua542IH9arwk39cG+1GWG1DVonOAw=; b=HNpmeZ6U8tnFHPuxdhj45PYwrlFf7dyzUBU6ki56BdZGtcENEE1EA8t8EZ6qRlHLnvtjhJ bruo2IIcx5mcZwFSyMDIzjUda+EceSCeKBTkvyi3ecCTI1tuUSJcvcSrG47qgA9xvdZg1Z Z1jSAeb5O0lpzDqsQUYlu5wWvlb0K/A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-538-KrfNesPcMlup5gEjNAAVEg-1; Tue, 13 Dec 2022 03:17:55 -0500 X-MC-Unique: KrfNesPcMlup5gEjNAAVEg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 589A3101E168; Tue, 13 Dec 2022 08:17:55 +0000 (UTC) Received: from [10.39.208.32] (unknown [10.39.208.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF329C15BAD; Tue, 13 Dec 2022 08:17:53 +0000 (UTC) Message-ID: Date: Tue, 13 Dec 2022 09:17:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] net/iavf: fix mbuf VLAN offload flags in the L2TAG2 path with AVX2 To: Michal Schmidt , dev@dpdk.org Cc: Bruce Richardson , Jingjing Wu , Beilei Xing , Haiyue Wang , "stable@dpdk.org" References: <20221208121916.155132-1-mschmidt@redhat.com> From: Maxime Coquelin In-Reply-To: <20221208121916.155132-1-mschmidt@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Michal, On 12/8/22 13:19, Michal Schmidt wrote: > It has been observed that mbufs of some received VLAN packets had the > VLAN tag correctly set in vlan_tci, but ol_flags were missing the > VLAN-indicating flags. > > _mm256_shuffle_epi8 operates as two independent 128-bit operations, > not as a single 256-bit operation. To have the RTE_MBUF_F_RX_VLAN* flags > reflected in the resulting vlan_flags for all 8 rx descriptors, the > input l2tag2_flags_shuf must contain the required pattern in both > 128-bit halves. > > Fixes: 3a1aca384d3a ("net/iavf: fix VLAN tag extraction handling") Adding stable ML since bug was introduced in v21.05: Cc: stable@dpdk.org Maybe no need to resubmit and maintainer can add it when applying. > > Signed-off-by: Michal Schmidt > --- > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rxtx_vec_avx2.c > index 862f6eb0c0..b4ebac9d34 100644 > --- a/drivers/net/iavf/iavf_rxtx_vec_avx2.c > +++ b/drivers/net/iavf/iavf_rxtx_vec_avx2.c > @@ -1074,7 +1074,10 @@ _iavf_recv_raw_pkts_vec_avx2_flex_rxd(struct iavf_rx_queue *rxq, > _mm256_set_epi8(0, 0, 0, 0, > 0, 0, 0, 0, > 0, 0, 0, 0, > - 0, 0, 0, 0, > + 0, 0, > + RTE_MBUF_F_RX_VLAN | > + RTE_MBUF_F_RX_VLAN_STRIPPED, > + 0, > /* end up 128-bits */ > 0, 0, 0, 0, > 0, 0, 0, 0, Reviewed-by: Maxime Coquelin Thanks, Maxime