From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C90D3A052A for ; Tue, 26 Jan 2021 18:29:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD9E3140F14; Tue, 26 Jan 2021 18:29:29 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 817BE140F0E; Tue, 26 Jan 2021 18:29:27 +0100 (CET) IronPort-SDR: OhG8yZV2nZC4ecnWRLGQegJT/PYFBvxVruDNeRYjgzfjXwfjG8BEAks4rbUjcYnPb7rSBxbrWG VYrag2pGDn6A== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="244018863" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="244018863" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 09:29:24 -0800 IronPort-SDR: on1rydVodWNoDXmxBL5+XNo9Va/CXn6tHOhgH26PphybqldwyZJyFxgkR4vzT4jI8TCTEkITfH Xt0tk1bSYh+A== X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="362062999" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.53]) ([10.213.227.53]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 09:29:22 -0800 To: Liron Himi , Jerin Jacob Kollanukkaran Cc: "dev@dpdk.org" , Yuri Chipchev , "stable@dpdk.org" , Andrew Rybchenko References: <20201202101212.4717-1-lironh@marvell.com> <20210122191925.24308-1-lironh@marvell.com> <20210122191925.24308-4-lironh@marvell.com> <53364cb0-389d-52a8-a282-c756336547d0@intel.com> From: Ferruh Yigit Message-ID: Date: Tue, 26 Jan 2021 17:29:18 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [EXT] Re: [PATCH v2 03/37] net/mvpp2: fix Rx/Tx bytes statistics X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 1/26/2021 5:25 PM, Liron Himi wrote: > > > -----Original Message----- > From: Ferruh Yigit > Sent: Tuesday, 26 January 2021 19:03 > To: Liron Himi ; Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Yuri Chipchev ; stable@dpdk.org; Andrew Rybchenko > Subject: [EXT] Re: [dpdk-stable] [PATCH v2 03/37] net/mvpp2: fix Rx/Tx bytes statistics > > External Email > > ---------------------------------------------------------------------- > On 1/22/2021 7:18 PM, lironh@marvell.com wrote: >> From: Yuri Chipchev >> >> 4B of CRC was not included in the bytes statistics >> >> Fixes: bdffe0c70 ("net/mrvl: support basic stats") >> Cc: stable@dpdk.org >> >> Signed-off-by: Yuri Chipchev >> Reviewed-by: Liron Himi >> --- >> drivers/net/mvpp2/mrvl_ethdev.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/mvpp2/mrvl_ethdev.c >> b/drivers/net/mvpp2/mrvl_ethdev.c index bfe496ff7..a1a3c0e31 100644 >> --- a/drivers/net/mvpp2/mrvl_ethdev.c >> +++ b/drivers/net/mvpp2/mrvl_ethdev.c >> @@ -1278,7 +1278,6 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) >> rx_stats.drop_fullq + >> rx_stats.drop_bm + >> rxq->drop_mac; >> - stats->ibytes += rxq->bytes_recv; >> drop_mac += rxq->drop_mac; >> } >> >> @@ -1306,7 +1305,6 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct >> rte_eth_stats *stats) >> >> stats->q_opackets[idx] = tx_stats.deq_desc; >> stats->q_obytes[idx] = txq->bytes_sent; >> - stats->obytes += txq->bytes_sent; >> } >> >> ret = pp2_ppio_get_statistics(priv->ppio, &ppio_stats, 0); @@ >> -1315,6 +1313,8 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) >> return ret; >> } >> >> + stats->ibytes += ppio_stats.rx_bytes; >> + stats->obytes += ppio_stats.tx_bytes; >> stats->ipackets += ppio_stats.rx_packets - drop_mac; >> stats->opackets += ppio_stats.tx_packets; >> stats->imissed += ppio_stats.rx_fullq_dropped + >> > > Is this patch adding CRC to the stats? If so that is wrong, stats should not have the CRC. > > A recent clarification from Andrew: > https://urldefense.proofpoint.com/v2/url?u=https-3A__patches.dpdk.org_patch_86975_&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=M6lEONY3jVnAkBjt0yC6oAsT7Jn2HI7LhNHCQYlnx1Q&m=iYhQSv2FUrmxLNQcxo6cAiLpoeqeTx1mQKadLot0jh0&s=lYaS0RY6n4QOlhzd3Z9PTxtR42lbqxPt1Pm1uODpWJg&e= > > [L.H.] okay, so based on this new clarification, this patch should not be merged to both next and stable branches. > thanks > sure, I can drop it in next-net.