From: "Pablo Cascón" <pablo.cascon@netronome.com>
Cc: stable@dpdk.org, Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: Re: [dpdk-stable] [PATCH 1/1] net/nfp: fix set_mac_addr
Date: Tue, 12 Mar 2019 11:24:58 +0000 [thread overview]
Message-ID: <df18391a-60ee-cf33-346a-e52cd425f394@netronome.com> (raw)
In-Reply-To: <1552059647-2725-1-git-send-email-pablo.cascon@netronome.com>
On 08/03/2019 15:40, Pablo Cascón wrote:
> Some firmwares, mostly for VFs, do not advertise the feature /
> capability of changing the MAC address while the interface is up. With
> such firmware a request to change the MAC address that at the same
> time also tries to enable the not available feature will be denied by
> the firmware resulting in an error message like:
>
> nfp_net_reconfig(): Error nfp_net reconfig for ctrl: 80000000 update: 800
>
> Fix set_mac_addr by not trying to enable a feature if it is not
> advertised by the firmware.
>
> Fixes: 2fe669f4bcd2 ("net/nfp: support MAC address change")
Sorry forgot to add here:
"Cc: stable@dpdk.org"
If needed please amend the commit message.
>
> Signed-off-by: Pablo Cascón <pablo.cascon@netronome.com>
> ---
> drivers/net/nfp/nfp_net.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index 54c6da9..278e154 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -566,7 +566,10 @@ nfp_set_mac_addr(struct rte_eth_dev *dev, struct ether_addr *mac_addr)
>
> /* Signal the NIC about the change */
> update = NFP_NET_CFG_UPDATE_MACADDR;
> - ctrl = hw->ctrl | NFP_NET_CFG_CTRL_LIVE_ADDR;
> + ctrl = hw->ctrl;
> + if ((hw->ctrl & NFP_NET_CFG_CTRL_ENABLE) &&
> + (hw->cap & NFP_NET_CFG_CTRL_LIVE_ADDR))
> + ctrl |= NFP_NET_CFG_CTRL_LIVE_ADDR;
> if (nfp_net_reconfig(hw, ctrl, update) < 0) {
> PMD_INIT_LOG(INFO, "MAC address update failed");
> return -EIO;
next prev parent reply other threads:[~2019-03-12 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 15:40 Pablo Cascón
2019-03-10 11:42 ` [dpdk-stable] [dpdk-dev] " Alejandro Lucero
2019-03-11 16:52 ` Ferruh Yigit
2019-03-12 11:24 ` Pablo Cascón [this message]
2019-04-12 9:21 ` [dpdk-stable] " Pablo Cascón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df18391a-60ee-cf33-346a-e52cd425f394@netronome.com \
--to=pablo.cascon@netronome.com \
--cc=alejandro.lucero@netronome.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).