From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7ED2BA0527 for ; Wed, 25 Nov 2020 10:16:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 66493C93C; Wed, 25 Nov 2020 10:16:28 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 397DDC93C for ; Wed, 25 Nov 2020 10:16:27 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id i2so1143399wrs.4 for ; Wed, 25 Nov 2020 01:16:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=ytaghlEgG+jxctTfh04whWOhQe0DS9Or45p5Je6Lzk8=; b=qhQ4AWrspasxEfWQzI+3Lai3zwMNqlf3ICLrhPQx9XkZT11F735xGTDj2YqnipsUrd XqWp7SIcUEysU7cRSrB7DIzz0aLO4tKFFxRBgojyGMXnfFiaEPvaOrVLHVjo6qtZczxK iYKtqKvd6ZPl1Je5ZQC3aCFr7UWkdZfV6G67R+hgxvPOCo9C2NGKtlaz8mfUuqD5Xk86 UTuZiXKeuU66jkemLBobicLH1+sKvDJ4fA08/3vwRIrtKd1//IXQPbHS5za6gqHQXTgB ojWvAgJwDjwT8NEoqYKA2K5juVvKxFSGYNKWIt/4mGo+rrGoJ/tSX8OkuqF+k9pZxL87 am2Q== X-Gm-Message-State: AOAM5307uN72vDL4IABrmkQKlkn4GR4snI+nIHdTCSfmbM/z4PpSVMwM FgPlyse50TYH6hTiusgc4aA= X-Google-Smtp-Source: ABdhPJx51cagrO0+Nl2bfmi4DbWShS/gdc+oKpEBXas59qdLraZO8KvPhDn3gpR+zOBe2BxecwC5Lw== X-Received: by 2002:adf:e801:: with SMTP id o1mr2913856wrm.3.1606295785931; Wed, 25 Nov 2020 01:16:25 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id v64sm3600431wme.25.2020.11.25.01.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 01:16:25 -0800 (PST) Message-ID: From: Luca Boccassi To: Lijun Ou , stable@dpdk.org Cc: linuxarm@huawei.com Date: Wed, 25 Nov 2020 09:16:24 +0000 In-Reply-To: <1606274683-41536-4-git-send-email-oulijun@huawei.com> References: <1605274630-23414-1-git-send-email-oulijun@huawei.com> <1606274683-41536-1-git-send-email-oulijun@huawei.com> <1606274683-41536-4-git-send-email-oulijun@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v2 19.11.6 3/7] net/hns3: report Tx descriptor segment limitations X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, 2020-11-25 at 11:24 +0800, Lijun Ou wrote: > [ upstream commit eb8b3a0d829bc109dfb13de9c8cdeacda5449e69 ] >=20 > According to the user manual of Kunpeng920 SoC, the max allowed number > of segments per whole packet is 63 and the max number of segments per > packet is 8 in datapath. >=20 > This patch reports the Two segment parameters of Tx descriptor > limitations to DPDK framework. >=20 > Signed-off-by: Lijun Ou > Signed-off-by: Wei Hu (Xavier) > --- > drivers/net/hns3/hns3_ethdev.c | 2 ++ > drivers/net/hns3/hns3_ethdev_vf.c | 2 ++ > 2 files changed, 4 insertions(+) >=20 > diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethde= v.c > index 3a92bd4..7fd0f7f 100644 > --- a/drivers/net/hns3/hns3_ethdev.c > +++ b/drivers/net/hns3/hns3_ethdev.c > @@ -2499,6 +2499,8 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, str= uct rte_eth_dev_info *info) > .nb_max =3D HNS3_MAX_RING_DESC, > .nb_min =3D HNS3_MIN_RING_DESC, > .nb_align =3D HNS3_ALIGN_RING_DESC, > + .nb_seg_max =3D HNS3_MAX_TSO_BD_PER_PKT, > + .nb_mtu_seg_max =3D HNS3_MAX_NON_TSO_BD_PER_PKT, > }; > =20 > info->vmdq_queue_num =3D 0; > diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_et= hdev_vf.c > index 4359b2e..0b5d3d4 100644 > --- a/drivers/net/hns3/hns3_ethdev_vf.c > +++ b/drivers/net/hns3/hns3_ethdev_vf.c > @@ -866,6 +866,8 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, str= uct rte_eth_dev_info *info) > .nb_max =3D HNS3_MAX_RING_DESC, > .nb_min =3D HNS3_MIN_RING_DESC, > .nb_align =3D HNS3_ALIGN_RING_DESC, > + .nb_seg_max =3D HNS3_MAX_TSO_BD_PER_PKT, > + .nb_mtu_seg_max =3D HNS3_MAX_NON_TSO_BD_PER_PKT, > }; > =20 > info->vmdq_queue_num =3D 0; Hi, Thanks for the series, but it fails to build, because of this patch: ../drivers/net/hns3/hns3_ethdev.c: In function =E2=80=98hns3_dev_infos_get= =E2=80=99: ../drivers/net/hns3/hns3_ethdev.c:2502:17: error: =E2=80=98HNS3_MAX_TSO_BD_= PER_PKT=E2=80=99 undeclared (first use in this function); did you mean =E2= =80=98HNS3_MAX_TX_BD_PER_PKT=E2=80=99? .nb_seg_max =3D HNS3_MAX_TSO_BD_PER_PKT, ^~~~~~~~~~~~~~~~~~~~~~~ HNS3_MAX_TX_BD_PER_PKT ../drivers/net/hns3/hns3_ethdev.c:2502:17: note: each undeclared identifier= is reported only once for each function it appears in ../drivers/net/hns3/hns3_ethdev.c:2503:21: error: =E2=80=98HNS3_MAX_NON_TSO= _BD_PER_PKT=E2=80=99 undeclared (first use in this function); did you mean = =E2=80=98HNS3_MAX_TX_BD_PER_PKT=E2=80=99? .nb_mtu_seg_max =3D HNS3_MAX_NON_TSO_BD_PER_PKT, ^~~~~~~~~~~~~~~~~~~~~~~~~~~ HNS3_MAX_TX_BD_PER_PKT [3/32] Compiling C object 'drivers/a715181@@tmp_rte_pmd_hns3@sta/net_hns3_h= ns3_intr.c.o'. ninja: build stopped: subcommand failed. --=20 Kind regards, Luca Boccassi