From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Siwar Zitouni <siwar.zitouni@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Thibaut Collet <thibaut.collet@6wind.com>
Subject: Re: [dpdk-stable] [PATCH] net/ice: fix disabling of promisc mode (keep allmulti state)
Date: Tue, 20 Apr 2021 14:08:03 +0000 [thread overview]
Message-ID: <e352c7e0583d4358ac8ac99781746da2@intel.com> (raw)
In-Reply-To: <20210419125348.25109-1-siwar.zitouni@6wind.com>
> -----Original Message-----
> From: Siwar Zitouni <siwar.zitouni@6wind.com>
> Sent: Monday, April 19, 2021 8:54 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Siwar Zitouni
> <siwar.zitouni@6wind.com>; stable@dpdk.org; Thibaut Collet
> <thibaut.collet@6wind.com>
> Subject: [PATCH] net/ice: fix disabling of promisc mode (keep allmulti state)
>
> When promiscuous mode is disabled, allmulticast is also disabled, even if it was
> previously enabled.
>
> Add a test in ice_promisc_disable()
> to check if allmulticast should be kept enabled.
>
> Fixes: c945e4bf9063 ("net/ice: support promiscuous mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thibaut Collet <thibaut.collet@6wind.com>
> Signed-off-by: Siwar Zitouni <siwar.zitouni@6wind.com>
> ---
> drivers/net/ice/ice_ethdev.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 84d173525..da9e85bd7 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -4526,8 +4526,11 @@ ice_promisc_disable(struct rte_eth_dev *dev)
> uint8_t pmask;
> int ret = 0;
>
> - pmask = ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX |
> - ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX;
> + if (dev->data->all_multicast == 1)
> + pmask = ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX;
> + else
> + pmask = ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX |
> + ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX;
>
> status = ice_clear_vsi_promisc(hw, vsi->idx, pmask, 0);
> if (status != ICE_SUCCESS) {
> --
> 2.30.2
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2021-04-20 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 12:53 Siwar Zitouni
2021-04-20 14:08 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e352c7e0583d4358ac8ac99781746da2@intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=siwar.zitouni@6wind.com \
--cc=stable@dpdk.org \
--cc=thibaut.collet@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).