From: Raslan Darawsheh <rasland@nvidia.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix modify field action on group 0
Date: Mon, 12 May 2025 09:24:46 +0300 [thread overview]
Message-ID: <e3b045a4-5347-4240-84b4-8dcf96fc7409@nvidia.com> (raw)
In-Reply-To: <20250425193258.38994-1-dsosnowski@nvidia.com>
Hi,
On 25/04/2025 10:32 PM, Dariusz Sosnowski wrote:
> HW modify header commands generated for multiple modify field
> flow actions, which modify/access the same packet fields
> do not have to be separated by NOPs when used on group 0.
> This is because:
>
> - On group > 0, HW uses Modify Header Pattern objects
> which require NOP explicitly.
> - On group 0, modify field action is implemented using
> Modify Header Context object managed by FW.
> FW inserts requires NOPs internally.
>
> mlx5 PMD inserted NOP always, which caused flow/table creation
> failures on group 0 flow rules.
> This patch addresses that.
>
> Fixes: 0f4aa72b99da ("net/mlx5: support flow modify field with HWS")
> Cc: suanmingm@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Bing Zhao <bingz@nvidia.com>
Patch applied to next-net-mlx,
--
Kindest regards
Raslan Darawsheh
prev parent reply other threads:[~2025-05-12 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 19:32 Dariusz Sosnowski
2025-05-12 6:24 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3b045a4-5347-4240-84b4-8dcf96fc7409@nvidia.com \
--to=rasland@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).