patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/ena/base: fix doorbell evaluation for the LLQ case
@ 2020-08-12 16:37 Artur Rojek
  2020-08-13 18:07 ` Marcin Wojtas
  0 siblings, 1 reply; 3+ messages in thread
From: Artur Rojek @ 2020-08-12 16:37 UTC (permalink / raw)
  To: Marcin Wojtas, Michal Krawczyk, Guy Tzalik, Igor Chauskin
  Cc: dev, stable, Artur Rojek

From: Michal Krawczyk <mk@semihalf.com>

This patch adds a missing LLQ-related check in the
ena_com_is_doorbell_needed() routine, which is relevant for the feature
supported by the next generation HW of the ENA.

Fixes: b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features")
CC: stable@dpdk.org

Signed-off-by: Michal Krawczyk <mk@semihalf.com>
[Extracted from a bigger patch]
Signed-off-by: Artur Rojek <ar@semihalf.com>
---
 drivers/net/ena/base/ena_eth_com.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ena/base/ena_eth_com.h b/drivers/net/ena/base/ena_eth_com.h
index e37b642d4..3d66237b8 100644
--- a/drivers/net/ena/base/ena_eth_com.h
+++ b/drivers/net/ena/base/ena_eth_com.h
@@ -133,7 +133,8 @@ static inline bool ena_com_is_doorbell_needed(struct ena_com_io_sq *io_sq,
 	llq_info = &io_sq->llq_info;
 	num_descs = ena_tx_ctx->num_bufs;
 
-	if (unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx)))
+	if (llq_info->disable_meta_caching ||
+	    unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx)))
 		++num_descs;
 
 	if (num_descs > llq_info->descs_num_before_header) {
-- 
2.28.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/ena/base: fix doorbell evaluation for the LLQ case
  2020-08-12 16:37 [dpdk-stable] [PATCH] net/ena/base: fix doorbell evaluation for the LLQ case Artur Rojek
@ 2020-08-13 18:07 ` Marcin Wojtas
  2020-08-18 15:26   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Marcin Wojtas @ 2020-08-13 18:07 UTC (permalink / raw)
  To: Artur Rojek; +Cc: Michal Krawczyk, Guy Tzalik, Igor Chauskin, dev, stable

Hi,

śr., 12 sie 2020 o 18:37 Artur Rojek <ar@semihalf.com> napisał(a):
>
> From: Michal Krawczyk <mk@semihalf.com>
>
> This patch adds a missing LLQ-related check in the
> ena_com_is_doorbell_needed() routine, which is relevant for the feature
> supported by the next generation HW of the ENA.
>
> Fixes: b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features")
> CC: stable@dpdk.org
>
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> [Extracted from a bigger patch]
> Signed-off-by: Artur Rojek <ar@semihalf.com>

Reviewed-by: Marcin Wojtas <mw@semihalf.com>

> ---
>  drivers/net/ena/base/ena_eth_com.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ena/base/ena_eth_com.h b/drivers/net/ena/base/ena_eth_com.h
> index e37b642d4..3d66237b8 100644
> --- a/drivers/net/ena/base/ena_eth_com.h
> +++ b/drivers/net/ena/base/ena_eth_com.h
> @@ -133,7 +133,8 @@ static inline bool ena_com_is_doorbell_needed(struct ena_com_io_sq *io_sq,
>         llq_info = &io_sq->llq_info;
>         num_descs = ena_tx_ctx->num_bufs;
>
> -       if (unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx)))
> +       if (llq_info->disable_meta_caching ||
> +           unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx)))
>                 ++num_descs;
>
>         if (num_descs > llq_info->descs_num_before_header) {
> --
> 2.28.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/ena/base: fix doorbell evaluation for the LLQ case
  2020-08-13 18:07 ` Marcin Wojtas
@ 2020-08-18 15:26   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-08-18 15:26 UTC (permalink / raw)
  To: Marcin Wojtas, Artur Rojek
  Cc: Michal Krawczyk, Guy Tzalik, Igor Chauskin, dev, stable

On 8/13/2020 7:07 PM, Marcin Wojtas wrote:
> Hi,
> 
> śr., 12 sie 2020 o 18:37 Artur Rojek <ar@semihalf.com> napisał(a):
>>
>> From: Michal Krawczyk <mk@semihalf.com>
>>
>> This patch adds a missing LLQ-related check in the
>> ena_com_is_doorbell_needed() routine, which is relevant for the feature
>> supported by the next generation HW of the ENA.
>>
>> Fixes: b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features")
>> CC: stable@dpdk.org
>>
>> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
>> [Extracted from a bigger patch]
>> Signed-off-by: Artur Rojek <ar@semihalf.com>
> 
> Reviewed-by: Marcin Wojtas <mw@semihalf.com>
> 

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-25 23:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-12 16:37 [dpdk-stable] [PATCH] net/ena/base: fix doorbell evaluation for the LLQ case Artur Rojek
2020-08-13 18:07 ` Marcin Wojtas
2020-08-18 15:26   ` Ferruh Yigit

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git