From: "Guo, Jia" <jia.guo@intel.com>
To: "Yu, DapengX" <dapengx.yu@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/e1000: remove MTU setting limitation
Date: Wed, 24 Feb 2021 03:37:32 +0000 [thread overview]
Message-ID: <e651de48d73640e8b5eeff90e912881d@intel.com> (raw)
In-Reply-To: <20210219100323.102093-1-dapengx.yu@intel.com>
Seems that this is align with the fixing process of the other pmds(ixgbe/txgbe) and it is not bad. Thanks.
Acked-by: Jeff Guo <jia.guo@intel.com>
> -----Original Message-----
> From: Yu, DapengX <dapengx.yu@intel.com>
> Sent: Friday, February 19, 2021 6:03 PM
> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/e1000: remove MTU setting limitation
>
> From: Dapeng Yu <dapengx.yu@intel.com>
>
> Currently, if requested MTU is bigger than mbuf size and scattered receive is
> not enabled, setting MTU to that value fails.
>
> This patch allows setting this special MTU when device is stopped, because
> scattered_rx will be re-configured during next port start and driver may
> enable scattered receive according new MTU value.
>
> After this patch, driver may select different receive function automatically
> after MTU set, according MTU values selected.
>
> Fixes: 59d0ecdbf0e1 ("ethdev: MTU accessors")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> ---
> drivers/net/e1000/em_ethdev.c | 12 ++++++++----
> drivers/net/e1000/igb_ethdev.c | 12 ++++++++----
> 2 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/e1000/em_ethdev.c
> b/drivers/net/e1000/em_ethdev.c index 9b8c4a7de..3c6f643c1 100644
> --- a/drivers/net/e1000/em_ethdev.c
> +++ b/drivers/net/e1000/em_ethdev.c
> @@ -1805,11 +1805,15 @@ eth_em_mtu_set(struct rte_eth_dev *dev,
> uint16_t mtu)
> if (mtu < RTE_ETHER_MIN_MTU || frame_size >
> dev_info.max_rx_pktlen)
> return -EINVAL;
>
> - /* refuse mtu that requires the support of scattered packets when
> this
> - * feature has not been enabled before. */
> - if (!dev->data->scattered_rx &&
> - frame_size > dev->data->min_rx_buf_size -
> RTE_PKTMBUF_HEADROOM)
> + /*
> + * If device is started, refuse mtu that requires the support of
> + * scattered packets when this feature has not been enabled before.
> + */
> + if (dev->data->dev_started && !dev->data->scattered_rx &&
> + frame_size > dev->data->min_rx_buf_size -
> RTE_PKTMBUF_HEADROOM) {
> + PMD_INIT_LOG(ERR, "Stop port first.");
> return -EINVAL;
> + }
>
> hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> rctl = E1000_READ_REG(hw, E1000_RCTL); diff --git
> a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index
> 5323504e9..1716d6b90 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4394,11 +4394,15 @@ eth_igb_mtu_set(struct rte_eth_dev *dev,
> uint16_t mtu)
> frame_size > dev_info.max_rx_pktlen)
> return -EINVAL;
>
> - /* refuse mtu that requires the support of scattered packets when
> this
> - * feature has not been enabled before. */
> - if (!dev->data->scattered_rx &&
> - frame_size > dev->data->min_rx_buf_size -
> RTE_PKTMBUF_HEADROOM)
> + /*
> + * If device is started, refuse mtu that requires the support of
> + * scattered packets when this feature has not been enabled before.
> + */
> + if (dev->data->dev_started && !dev->data->scattered_rx &&
> + frame_size > dev->data->min_rx_buf_size -
> RTE_PKTMBUF_HEADROOM) {
> + PMD_INIT_LOG(ERR, "Stop port first.");
> return -EINVAL;
> + }
>
> rctl = E1000_READ_REG(hw, E1000_RCTL);
>
> --
> 2.27.0
next prev parent reply other threads:[~2021-02-24 3:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 10:03 dapengx.yu
2021-02-24 3:37 ` Guo, Jia [this message]
2021-02-24 12:18 ` Zhang, Qi Z
-- strict thread matches above, loose matches on Subject: below --
2021-02-07 9:40 dapengx.yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e651de48d73640e8b5eeff90e912881d@intel.com \
--to=jia.guo@intel.com \
--cc=dapengx.yu@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).