From: Ferruh Yigit <email@example.com>
To: Thomas Monjalon <firstname.lastname@example.org>,
Gregory Etelson <email@example.com>,
Cc: Matan Azrad <firstname.lastname@example.org>,
Raslan Darawsheh <email@example.com>,
Viacheslav Ovsiienko <firstname.lastname@example.org>,
Shahaf Shuler <email@example.com>, Asaf Penso <firstname.lastname@example.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix tunnel offload private items location
Date: Mon, 26 Apr 2021 08:54:34 +0100 [thread overview]
Message-ID: <email@example.com> (raw)
On 4/25/2021 6:07 PM, Thomas Monjalon wrote:
> Dim 25 avr 2021, à 19:01, Gregory Etelson a écrit :
>> Hello Thomas,
>>> Dim 25 avr 2021, à 17:57, Gregory Etelson a écrit :
>>>> Tunnel offload API requires application to query PMD for specific flow
>>>> items and actions. Application uses these PMD specific elements to
>>>> build flow rules according to the tunnel offload model.
>>>> The model does not restrict private elements location in a flow rule,
>>>> but the current MLX5 PMD implementation expects that tunnel offload
>>>> rule will begin with PMD specific elements.
>>>> The patch removes that placement limitation in MLX5 PMD.
>>>> Cc: firstname.lastname@example.org
>>>> Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
>>> Cc: stable must be just after the Fixes line.
>>> There is a testpmd patch in the same series, is it OK to be merged in mlx
>> The tunnel offload model can be complicated.
>> The testpmd patch that comes with this one emphasizes how application
>> can construct a flow rule without placement restrictions.
>> I think that both patches should be merged.
> That's not the question.
> One patch should be merged in mlx tree, while the other one should target next-net.
> In such a situation, quite often we split in different series.
> For this case, it's up to Raslan and Ferruh to agree on how to proceed.
I am OK to get both to next-net, as long as driver patch is Ack'ed.
It seems there is a relation between driver and testpmd patch, but I am trying
to figure out how tightly they are coupled, which may be sign of something wrong.
next prev parent reply other threads:[~2021-04-26 7:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 13:02 [dpdk-stable] [PATCH " Gregory Etelson
2021-04-19 13:02 ` [dpdk-stable] [PATCH 2/2] app/testpmd: " Gregory Etelson
2021-04-23 8:50 ` Ferruh Yigit
2021-04-25 15:57 ` [dpdk-stable] [PATCH v2 1/2] net/mlx5: " Gregory Etelson
2021-04-25 15:57 ` [dpdk-stable] [PATCH v2 2/2] app/testpmd: " Gregory Etelson
2021-04-30 13:49 ` Ferruh Yigit
2021-04-25 16:28 ` [dpdk-stable] [dpdk-dev] [PATCH v2 1/2] net/mlx5: " Thomas Monjalon
2021-04-25 17:01 ` Gregory Etelson
2021-04-25 17:07 ` Thomas Monjalon
2021-04-26 7:54 ` Ferruh Yigit [this message]
2021-04-27 9:27 ` Gregory Etelson
2021-04-29 7:44 ` Gregory Etelson
2021-04-30 13:37 ` Ferruh Yigit
2021-05-04 9:20 ` Gregory Etelson
2021-05-02 8:08 ` [dpdk-stable] [PATCH v3] " Gregory Etelson
2021-05-04 8:10 ` Raslan Darawsheh
2021-05-04 8:20 ` Ferruh Yigit
2021-05-04 9:12 ` Gregory Etelson
2021-05-05 17:45 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2021-05-06 6:08 ` Gregory Etelson
2021-05-06 7:40 ` Gregory Etelson
2021-05-06 7:59 ` [dpdk-stable] [dpdk-dev] net/mlx5: mellanox cx5/cx6-dx increment "rx_phy_discard_packets" with DPDK rte_flow actions COUNT & DROP Arthas
2021-05-06 9:57 ` [dpdk-stable] [PATCH v4] net/mlx5: fix tunnel offload private items location Gregory Etelson
2021-05-11 22:16 ` Ferruh Yigit
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).