From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35C0EA04B0 for ; Fri, 7 Aug 2020 16:53:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D47E92BF1; Fri, 7 Aug 2020 16:53:06 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 082C32BF1 for ; Fri, 7 Aug 2020 16:53:06 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id 184so2126928wmb.0 for ; Fri, 07 Aug 2020 07:53:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=F7j1uerrqygkD2+zecb2rYR51qgX56YAnKUXL6WhozE=; b=SuXb6TFHFGddfeqo1vMhCZyIWToe/uV9nMV2jYB7rYH/Bl1UKnTUakbV8WFNTtxrlN 9dLJh3WwJAB/sBm/KvURR5THVI5kgZOg+GVlI81RjbVUdHHYYos4JOMiimBfCi+QMLsu CR6DsqkNSGXjQ/9fg0qrHJSL3lIvAimOz58xA54izYapwH0vvP3FUvl+R/phuszLZuFd OI0lnd0ZSW+gXogAqiUUXDbMSwQFmtIhhgXWqYrW8oa5SE62rZHYmSdR4k3Ka/zn5z2/ qYFt+NKX7alh0T4cQtS2FzylJb9WWltz9IBJjSy6wNbt9nNTUFFwv59od/mL/G3AGrXS dseA== X-Gm-Message-State: AOAM531mHcWwOUIyHd1gJM68unAyheUmQkzZar1rMGfL7mgH7MFwtogP aL0n9T0BwxN+WH58jwoCDQi7N3SuDkc= X-Google-Smtp-Source: ABdhPJwg/nsm1t7ZYf6vRlXECccGNaUc6oSMaYYEyxvhykSIqL0Vff0eBMFiCoVetJUOgoXZOgBQ4g== X-Received: by 2002:a05:600c:2189:: with SMTP id e9mr13907658wme.171.1596811985647; Fri, 07 Aug 2020 07:53:05 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id w10sm10734914wmk.0.2020.08.07.07.53.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 07:53:03 -0700 (PDT) Message-ID: From: Luca Boccassi To: Arek Kusztal , fiona.trahe@intel.com Cc: stable@dpdk.org Date: Fri, 07 Aug 2020 15:53:02 +0100 In-Reply-To: <20200807125701.1764-4-arkadiuszx.kusztal@intel.com> References: <20200807125701.1764-1-arkadiuszx.kusztal@intel.com> <20200807125701.1764-4-arkadiuszx.kusztal@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [19.11 4/4] crypto/qat: add minimum enq threshold X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, 2020-08-07 at 14:57 +0200, Arek Kusztal wrote: > [ upstream commit 47c3f7a41a26c9943f9804691d03828b2ce09f40 ] >=20 > This patch adds minimum enqueue threshold to Intel > QuickAssist Technology PMD. > It is an optimisation, configured by a command line option, > which can be used to reduce MMIO write occurrences. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Fiona Trahe > Signed-off-by: Arek Kusztal > --- > doc/guides/cryptodevs/qat.rst | 18 +++++++ > drivers/common/qat/qat_common.c | 3 ++ > drivers/common/qat/qat_common.h | 3 ++ > drivers/common/qat/qat_device.c | 99 +++++++++++++++++++++++++++++++= +----- > drivers/common/qat/qat_device.h | 22 +++++++-- > drivers/common/qat/qat_qp.c | 10 ++++ > drivers/common/qat/qat_qp.h | 3 ++ > drivers/compress/qat/qat_comp_pmd.c | 14 +++++- > drivers/compress/qat/qat_comp_pmd.h | 4 +- > drivers/crypto/qat/qat_asym_pmd.c | 14 +++++- > drivers/crypto/qat/qat_asym_pmd.h | 4 +- > drivers/crypto/qat/qat_sym_pmd.c | 14 +++++- > drivers/crypto/qat/qat_sym_pmd.h | 4 +- > 13 files changed, 190 insertions(+), 22 deletions(-) >=20 > diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rs= t > index 5135703..aa3cdcf 100644 > --- a/doc/guides/cryptodevs/qat.rst > +++ b/doc/guides/cryptodevs/qat.rst > @@ -273,6 +273,24 @@ allocated while for GEN1 devices, 12 buffers are all= ocated, plus 1472 bytes over > larger than the input size). > =20 > =20 > +Running QAT PMD with minimum threshold for burst size > +~~~~~~~~~~~~~~~~~~~~~~~~ > + > +If only a small number or packets can be enqueued. Each enqueue causes a= n expensive MMIO write. > +These MMIO write occurrences can be optimised by setting any of the foll= owing parameters > +- qat_sym_enq_threshold > +- qat_asym_enq_threshold > +- qat_comp_enq_threshold > +When any of these parameters is set rte_cryptodev_enqueue_burst function= will > +return 0 (thereby avoiding an MMIO) if the device is congested and numbe= r of packets > +possible to enqueue is smaller. > +To use this feature the user must set the parameter on process start as = a device additional parameter: > + .example: '-w 03:01.1,qat_sym_enq_threshold=3D32,qat_comp_enq_threshold= =3D16' > +All parameters can be used with the same device regardless of order. Par= ameters are separated > +by comma. When the same parameter is used more than once first occurrenc= e of the parameter > +is used. > +Maximum threshold that can be set is 32. > + > Device and driver naming > ~~~~~~~~~~~~~~~~~~~~~~~ Normally I wouldn't accept a patch that adds new command line features, but given it's restricted to a single PMD _and_ the feature is present in the first short term release after 19.11 (20.02) thus allowing non- breaking upgrades, I'll merge the series. --=20 Kind regards, Luca Boccassi