From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DD9F3A0A0B
	for <public@inbox.dpdk.org>; Mon, 25 Jan 2021 10:13:14 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C60B7140DF7;
	Mon, 25 Jan 2021 10:13:14 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 47A8E140DE5;
 Mon, 25 Jan 2021 10:13:12 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 9DD097F40D;
 Mon, 25 Jan 2021 12:13:11 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 9DD097F40D
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1611565991;
 bh=GZhUrkDajYi2i4LL3VU6XHb0gPGaLE83kS1pzPfS648=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=un/HDJAt7N7f6AMBANWxiypfqcPFLhO3Ro2P2NdwDuil9eg+G9NwUyP0Di3yVavrr
 6QzUapAdiueB8ylId9gym8hQ+/20NqqhCyqf5ep8/+Sehid16OFGIJ2/HdIBmkswUK
 oJphEzHs6tbEZQfibRY95ftWVaF787aeqCkBT4OU=
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: stable@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Liron Himi <lironh@marvell.com>,
 Stephen Hemminger <stephen@networkplumber.org>
References: <20210122175804.772207-1-thomas@monjalon.net>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <e96f6ae7-0be7-5ad7-dd8c-f731d7443b54@oktetlabs.ru>
Date: Mon, 25 Jan 2021 12:13:11 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210122175804.772207-1-thomas@monjalon.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [PATCH 1/1] ethdev: fix handling of close failure
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

On 1/22/21 8:58 PM, Thomas Monjalon wrote:
> If a failure happens when closing a port,
> it was unnecessarily failing again in the function eth_err(),
> because of a check against HW removal cause.
> Indeed there is a big chance the port is released at this point.
> Given the port is in the middle (or at the end) of a close process,
> checking the error cause by accessing the port is a non-sense.
> The error check is replaced by a simple return in the close function.
> 
> Bugzilla ID: 624
> Fixes: 8a5a0aad5d3e ("ethdev: allow close function to return an error")
> Cc: stable@dpdk.org
> 
> Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>