patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org
Cc: stable@dpdk.org, Rohit Raj <rohit.raj@nxp.com>
Subject: Re: [dpdk-stable] [PATCH v4 2/9] net/dpaa2: fix 10g port negotiation issue
Date: Thu, 7 May 2020 15:36:08 +0100
Message-ID: <ebe81690-c679-798f-67aa-8f68ee3aa625@intel.com> (raw)
In-Reply-To: <20200507104645.31990-3-hemant.agrawal@nxp.com>

On 5/7/2020 11:46 AM, Hemant Agrawal wrote:
> From: Rohit Raj <rohit.raj@nxp.com>
> 

s/10g/10G in the title

> Fixed 10g port negotiation issue with another 10G/non 10G port.

Can be good to explain how it is fixed.

> Initialize the port link speed.
> 
> Fixes: c5acbb5ea20e ("net/dpaa2: support link status event")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
> ---
>  drivers/net/dpaa2/dpaa2_ethdev.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
> index 2cde55e7cc..4fc550a885 100644
> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> @@ -553,9 +553,6 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev)
>  	if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
>  		dpaa2_vlan_offload_set(dev, ETH_VLAN_FILTER_MASK);
>  
> -	/* update the current status */
> -	dpaa2_dev_link_update(dev, 0);
> -
>  	return 0;
>  }
>  
> @@ -1757,6 +1754,7 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)
>  	/* changing tx burst function to start enqueues */
>  	dev->tx_pkt_burst = dpaa2_dev_tx;
>  	dev->data->dev_link.link_status = state.up;
> +	dev->data->dev_link.link_speed = state.rate;
>  
>  	if (state.up)
>  		DPAA2_PMD_INFO("Port %d Link is Up", dev->data->port_id);
> 


  reply	other threads:[~2020-05-07 14:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200302145829.27808-1-hemant.agrawal@nxp.com>
2020-03-02 14:58 ` [dpdk-stable] [PATCH 01/16] " Hemant Agrawal
2020-03-02 14:58 ` [dpdk-stable] [PATCH 02/16] bus/fslmc: fix dereferencing null pointer Hemant Agrawal
     [not found] ` <20200306095742.18080-1-hemant.agrawal@nxp.com>
2020-03-06  9:57   ` [dpdk-stable] [PATCH v2 01/16] net/dpaa2: fix 10g port negotiation issue Hemant Agrawal
2020-03-06  9:57   ` [dpdk-stable] [PATCH v2 02/16] bus/fslmc: fix dereferencing null pointer Hemant Agrawal
     [not found]   ` <20200504124118.22877-1-hemant.agrawal@nxp.com>
2020-05-04 12:41     ` [dpdk-stable] [PATCH v3 1/8] " Hemant Agrawal
2020-05-06 21:08       ` Ferruh Yigit
2020-05-06 21:09         ` Ferruh Yigit
2020-05-06 21:14       ` Ferruh Yigit
2020-05-04 12:41     ` [dpdk-stable] [PATCH v3 2/8] net/dpaa2: fix 10g port negotiation issue Hemant Agrawal
     [not found]     ` <20200507104645.31990-1-hemant.agrawal@nxp.com>
2020-05-07 10:46       ` [dpdk-stable] [PATCH v4 1/9] bus/fslmc: fix dereferencing null pointer Hemant Agrawal
2020-05-07 10:46       ` [dpdk-stable] [PATCH v4 2/9] net/dpaa2: fix 10g port negotiation issue Hemant Agrawal
2020-05-07 14:36         ` Ferruh Yigit [this message]
2020-05-07 10:46       ` [dpdk-stable] [PATCH v4 8/9] net/dpaa2: fix cong group id for multiple tcs Hemant Agrawal
2020-05-07 14:33         ` Ferruh Yigit
2020-05-07 10:46       ` [dpdk-stable] [PATCH v4 9/9] bus/fslmc: fix the size of qman fq desc Hemant Agrawal
     [not found]       ` <20200508125934.14255-1-hemant.agrawal@nxp.com>
2020-05-08 12:59         ` [dpdk-stable] [PATCH v5 1/9] net/dpaa2: fix 10G port negotiation issue Hemant Agrawal
2020-05-08 12:59         ` [dpdk-stable] [PATCH v5 7/9] net/dpaa2: fix cong group id for multiple tcs Hemant Agrawal
2020-05-08 12:59         ` [dpdk-stable] [PATCH v5 8/9] bus/fslmc: fix the size of qman fq desc Hemant Agrawal
     [not found]       ` <20200508130211.14334-1-hemant.agrawal@nxp.com>
2020-05-08 13:02         ` [dpdk-stable] [PATCH v6 01/10] bus/fslmc: fix dereferencing null pointer Hemant Agrawal
2020-05-08 13:02         ` [dpdk-stable] [PATCH v6 02/10] net/dpaa2: fix 10G port negotiation issue Hemant Agrawal
2020-05-08 13:02         ` [dpdk-stable] [PATCH v6 08/10] net/dpaa2: fix cong group id for multiple tcs Hemant Agrawal
2020-05-08 13:02         ` [dpdk-stable] [PATCH v6 09/10] bus/fslmc: fix the size of qman fq desc Hemant Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebe81690-c679-798f-67aa-8f68ee3aa625@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=rohit.raj@nxp.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git