From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD2BFA00C2 for ; Wed, 23 Nov 2022 19:14:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2A0842DA3; Wed, 23 Nov 2022 19:14:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D823640E5A for ; Wed, 23 Nov 2022 19:14:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669227260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BBe6Wodtxo5jbJ8ExEFVD2pGsttTlrxrn65ZpNKHJm0=; b=gOSLaWLWefLAmNQgNGmw1kJi7DbL+f+9WyRD+zWPxLksTXUxQjJ54DhinMlPbieR1FYbdS 9Ft02lvCUaHHm1JfsWXSbOrcrQ0ziaq703hkcHEJNm8Ne/sT+iS1+e03f4QJuWJ7Xlzbo7 qT0CUW3HKxEvBpSCAHiKtm4/Sv4c75I= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-549-q0p-NBZFMFCw0cxWbgwU7w-1; Wed, 23 Nov 2022 13:14:18 -0500 X-MC-Unique: q0p-NBZFMFCw0cxWbgwU7w-1 Received: by mail-wm1-f70.google.com with SMTP id f1-20020a1cc901000000b003cf703a4f08so1068867wmb.2 for ; Wed, 23 Nov 2022 10:14:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BBe6Wodtxo5jbJ8ExEFVD2pGsttTlrxrn65ZpNKHJm0=; b=WzW0i59cznwH0wg9tQ305CeUYl88vaHT0jmSZaU839FBFlwZEhQ6XdnekCzbXBmBi4 odgI+kV7us/vW9oc+XwlaHgjD8YE1tMR1lsvvLvuwUofXrDiv7PXlk1Nm8foMBQbTDLJ s6+vigeadU4heUm76Q0ZLRgd3YT7IknWQvaFFVs7p4YEwQz/WwUsz5O8c0o1IWX53etH p6xxBE1uo17MTrF1kCL1j7YlHKt7kiuQLhpUCjmoMZWIoPBO0w5Ld8YieKcNoBI8VKKS qHHRU5qIw83PZoxt+c0a8e/vRwkFXPjacwyoOwMXW0Ct0j+g89s8n8MwIRr+HeJbw3ow SBTw== X-Gm-Message-State: ANoB5pnuBHJli95l79QVUW5Xp4GHbAEKzTWagjRXkFWKh4yJBM1J2u5k X3PY0nGH5yq7F4aJqR3vOYZHXFrzLhOJFKwwU1zCONfZa8QTaWHOO++TqD79XOeLNXyUpiVclEK CoWWBu/k= X-Received: by 2002:a05:600c:3ca0:b0:3cf:615f:54fb with SMTP id bg32-20020a05600c3ca000b003cf615f54fbmr14122598wmb.76.1669227257585; Wed, 23 Nov 2022 10:14:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf55RX+FMbHUoXnCYXbtvCfjfYhFb20a8fx3/dy3FqSBtYxsiCun4vvTe51s7lZbsGRd+SfZpA== X-Received: by 2002:a05:600c:3ca0:b0:3cf:615f:54fb with SMTP id bg32-20020a05600c3ca000b003cf615f54fbmr14122587wmb.76.1669227257345; Wed, 23 Nov 2022 10:14:17 -0800 (PST) Received: from [192.168.0.36] ([78.19.108.40]) by smtp.gmail.com with ESMTPSA id u16-20020adfdd50000000b00228d52b935asm17526024wrm.71.2022.11.23.10.14.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Nov 2022 10:14:16 -0800 (PST) Message-ID: Date: Wed, 23 Nov 2022 18:14:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 21.11] net/bonding: fix flow flush order on close To: Ivan Malov , stable@dpdk.org Cc: Andrew Rybchenko References: <20221114112450.3153119-1-ivan.malov@oktetlabs.ru> From: Kevin Traynor In-Reply-To: <20221114112450.3153119-1-ivan.malov@oktetlabs.ru> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 14/11/2022 11:24, Ivan Malov wrote: > [ upstream commit df810d1b6e31a3e25085a6abae3be119af3034c1 ] > > The current code first removes all back-end devices of > the bonded device and then invokes flush operation to > remove flows in such back-end devices, which makes no > sense. Fix that by re-ordering the steps accordingly. > > Fixes: 49dad9028e2a ("net/bonding: support flow API") > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > --- Thanks for the backport, this is pushed to 21.11 branch now. > drivers/net/bonding/rte_eth_bond_pmd.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index c88ba2ae42..707c22a7a4 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -2155,6 +2155,10 @@ bond_ethdev_close(struct rte_eth_dev *dev) > return 0; > > RTE_BOND_LOG(INFO, "Closing bonded device %s", dev->device->name); > + > + /* Flush flows in all back-end devices before removing them */ > + bond_flow_ops.flush(dev, &ferror); > + > while (internals->slave_count != skipped) { > uint16_t port_id = internals->slaves[skipped].port_id; > > @@ -2172,7 +2176,6 @@ bond_ethdev_close(struct rte_eth_dev *dev) > skipped++; > } > } > - bond_flow_ops.flush(dev, &ferror); > bond_ethdev_free_queues(dev); > rte_bitmap_reset(internals->vlan_filter_bmp); > rte_bitmap_free(internals->vlan_filter_bmp);