From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DBB8A0548 for ; Wed, 21 Apr 2021 11:04:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53C3641A1A; Wed, 21 Apr 2021 11:04:38 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 7E9ED419D3; Wed, 21 Apr 2021 11:04:36 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 0C6D37F4F8; Wed, 21 Apr 2021 12:04:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 0C6D37F4F8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1618995876; bh=zTQ2SmalzkcchGPHCdb/946fwm5TLOL3QKuQCmkyc+E=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=ykwwhXdakekfF6P2SK6tZEfDJJexJ86Lrrz4fEyFG2Bu+u4xJ7cpPtCF8GdTKmHxn qi6zgafMvYCRUyrwBTIKVdXn4y1B7i3HgalxVBk8XhyLQaLR0YAf7d6+m9qOJ5+5n9 UHsnawrssT0uxSHmltjXXhkQG3V/836PzUAUEIak= To: =?UTF-8?Q?Juraj_Linke=c5=a1?= , thomas@monjalon.net, david.marchand@redhat.com, bruce.richardson@intel.com, aconole@redhat.com, maicolgabriel@hotmail.com Cc: dev@dpdk.org, Ruifeng Wang , arybchenko@solarflare.com, stable@dpdk.org References: <1615988163-17371-1-git-send-email-juraj.linkes@pantheon.tech> <1618995020-4775-1-git-send-email-juraj.linkes@pantheon.tech> <1618995020-4775-2-git-send-email-juraj.linkes@pantheon.tech> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Wed, 21 Apr 2021 12:04:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <1618995020-4775-2-git-send-email-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 4/21/21 11:50 AM, Juraj Linkeš wrote: > From: Ruifeng Wang > > The sfc PMD was enabled for aarch32 which is 32-bit mode but has > cpu_family set to aarch64. > As sfc support only 64-bit system, it should be disabled for aarch32. > > Updated meson file to disable sfc for aarch32 build. > > Fixes: 141d2870675a ("net/sfc: support aarch64 architecture") > Cc: arybchenko@solarflare.com > Cc: stable@dpdk.org > > Signed-off-by: Ruifeng Wang > Acked-by: Andrew Rybchenko Withdraw my ack > --- > drivers/common/sfc_efx/meson.build | 2 +- > drivers/net/sfc/meson.build | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/common/sfc_efx/meson.build b/drivers/common/sfc_efx/meson.build > index 1ca9510733..db5a6a8b42 100644 > --- a/drivers/common/sfc_efx/meson.build > +++ b/drivers/common/sfc_efx/meson.build > @@ -10,7 +10,7 @@ if is_windows > reason = 'not supported on Windows' > endif > > -if (arch_subdir != 'x86' or not dpdk_conf.get('RTE_ARCH_64')) and (arch_subdir != 'arm' or not host_machine.cpu_family().startswith('aarch64')) > +if (arch_subdir != 'x86' or arch_subdir != 'arm') and (not dpdk_conf.get('RTE_ARCH_64')) Am I missing something or condition in parenthesis is always true? I think it should be: if arch_subdir != 'x86' or arch_subdir != 'arm' or not dpdk_conf.get('RTE_ARCH_64') > build = false > reason = 'only supported on x86_64 and aarch64' > endif > diff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build > index 0c5cfb9058..0a96235e33 100644 > --- a/drivers/net/sfc/meson.build > +++ b/drivers/net/sfc/meson.build > @@ -12,7 +12,7 @@ if is_windows > subdir_done() > endif > > -if (arch_subdir != 'x86' or not dpdk_conf.get('RTE_ARCH_64')) and (arch_subdir != 'arm' or not host_machine.cpu_family().startswith('aarch64')) > +if (arch_subdir != 'x86' or arch_subdir != 'arm') and (not dpdk_conf.get('RTE_ARCH_64')) same here. > build = false > reason = 'only supported on x86_64 and aarch64' > endif >