From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id A0BF41DB8 for ; Wed, 18 Jul 2018 10:38:15 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id s14-v6so1959293wmc.1 for ; Wed, 18 Jul 2018 01:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=cGei80dNrxVN4LBbHU+F3pKOVm6XemM1Sm04z4qsDTk=; b=QuaQQFDRmf3JhUVxqvmLsSqx25lRyNy78nxn5WiP0Fc1UrKo2KVPSvwS4bmFPL2QZz bvHOyUU7TS7Ms91xrhioQfOpib75byTFLkBtnOXxocoSfEJ/X9xGx02Buz44Sw3mEBcp E/j6ROBp0KDLvM6Tyj/Va/PzkqwBPKc3dEvWsrmlC525CVs0ovCipp2lDUStrQGnqAz+ ylciahaFhPElyUmn9TuDVyyje/W6HDYfINl/YErEXtyl0GiJe4TlqGMeyK4lI82RXq6d zTO0AVnvuEcteMgpikrjbJfg4WogtNRSBZeTsKKgHII9UNHKNAZr2ybW4Snk4tw3QJjR MzDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=cGei80dNrxVN4LBbHU+F3pKOVm6XemM1Sm04z4qsDTk=; b=NYIwoLLKhlsZTBqf5SablAL+6SrSGgFXudtH0RG79vjbFkmph4dRwQiCICQ3phyBt/ lKQ0EuQCximw3P2PrvDhqL2IhSbXloAewF1u0eK9/b3Ye4YNFsSSh89inzjqwHfTR8Sl /vxnxYEag7gIbSoeKlaOvgDEMIZzI8w2BDyuCeR6QGpn77V9GXMtS4gxCG9ECq3tv2Jh Ii+5Pl+QqLlbr/Wwrk3/tSB2Aka5VFaKt0VekXA6CDtCpsb3CVVwyrke8CPwDBFp7sq8 PlirKD1B7G/pmtoMWbKGTJebdwYMQcmcxRDkNgR2Atc1qi7fBHHmN1hIZ8KyRhgNJRzG WKOw== X-Gm-Message-State: AOUpUlGOCCd+S6pLbTqJD4qYDQz80nd5xIlIs87TLj6Ew6NY15IARmPS V1hp4a7cAx+8Mt9mGJHYpywIMZ0HBQ== X-Google-Smtp-Source: AAOMgpdcvdMvv/M1RLRbMaJ+YTmWUPFo65NG3GSFzefci5iLKSBhIgQQzeTxBX5Xds1hDT1nl1xcEA== X-Received: by 2002:a1c:1609:: with SMTP id 9-v6mr956061wmw.12.1531903095036; Wed, 18 Jul 2018 01:38:15 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v10-v6sm5123877wrm.18.2018.07.18.01.38.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jul 2018 01:38:14 -0700 (PDT) From: Nelio Laranjeiro To: stable@dpdk.org, Yongseok Koh , Luca Boccassi Date: Wed, 18 Jul 2018 10:37:53 +0200 Message-Id: X-Mailer: git-send-email 2.18.0 Subject: [dpdk-stable] [PATCH] net/mlx5: fix silent error for unsupported flow items X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2018 08:38:15 -0000 Not supported items are causing a silent error which does not stops the conversion of the flow rule. This silent error ends in case of a flow create by segmentation fault. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") Signed-off-by: Nelio Laranjeiro --- The commit impacts the following stable branches: v17.02, v17.05, v17.08, v17.11, v18.02, v18.05 --- drivers/net/mlx5/mlx5_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index f48b68945..8ebc0928b 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -801,8 +801,10 @@ mlx5_flow_convert_items_validate(const struct rte_flow_item items[], break; } } - if (!token) + if (!token) { + ret = -ENOTSUP; goto exit_item_not_supported; + } cur_item = token; ret = mlx5_flow_item_validate(items, (const uint8_t *)cur_item->mask, -- 2.18.0