From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7D906A0C43
	for <public@inbox.dpdk.org>; Thu, 30 Sep 2021 15:45:02 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 691D84111C;
	Thu, 30 Sep 2021 15:45:02 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id E2EF4410EA;
 Thu, 30 Sep 2021 15:45:00 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 62CD77F6BC;
 Thu, 30 Sep 2021 16:45:00 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 62CD77F6BC
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1633009500;
 bh=9EibKfEY+Kj/MpWtZHT2Bo1yPU0LElCqfkBEdhU9K7w=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=SMwtvVNFFlZRsjXMLe7yhIwwI99euBAPQecl2WOKPnx982A+1Rip9rxq1hAarE8JB
 ll5rX3up5CjjIEySqrV9rhoSd7ZU+851jidl63V6uwvOUyBlYwcW52Q6Mckjwo690e
 4/chf1ND4nxkpVSNJ4j1fNKXdF293wFhCkBEP/0g=
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>
Cc: Rasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@oss.nxp.com>,
 Haiyue Wang <haiyue.wang@intel.com>, Gagandeep Singh <g.singh@nxp.com>,
 John Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>,
 Beilei Xing <beilei.xing@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Shijith Thotton <sthotton@marvell.com>,
 Srisivasubramanian Srinivasan <srinivasan@marvell.com>,
 Zyta Szpak <zr@semihalf.com>, Liron Himi <lironh@marvell.com>,
 Harman Kalra <hkalra@marvell.com>, Xiao Wang <xiao.w.wang@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org, stable@dpdk.org
References: <20210928141627.904787-1-andrew.rybchenko@oktetlabs.ru>
 <20210928164854.1092217-1-andrew.rybchenko@oktetlabs.ru>
 <20210928101054.0f6ad088@hermes.local>
 <20f9d684-4a15-b870-672f-7301bd0503a0@oktetlabs.ru>
 <4b39a7ed-2367-b3f2-10d6-6f3d5fc719be@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <efc6dbd2-51ef-6df3-cb14-da284ab50768@oktetlabs.ru>
Date: Thu, 30 Sep 2021 16:45:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <4b39a7ed-2367-b3f2-10d6-6f3d5fc719be@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] drivers/net: remove queue
 xstats auto-fill flag
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

On 9/30/21 4:00 PM, Ferruh Yigit wrote:
> On 9/29/2021 7:38 AM, Andrew Rybchenko wrote:
>> On 9/28/21 8:10 PM, Stephen Hemminger wrote:
>>> On Tue, 28 Sep 2021 19:48:54 +0300
>>> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:
>>>
>>>> Some drivers do not provide per-queue statistics. So, there is no point
>>>> to have these misleading zeros in xstats.
>>>>
>>>> Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>> Really?
>>> It is useful to have zeros rather than random data there.
>>
>> I guess there is a misunderstanding here. Auto-filling xstats is
>> an addition of per-queue basic statistics to xstats by ethdev
>> layer. It makes sense to do it if and only if there is some
>> sensible data there.
>>
>> There is a related deprecation notice saying that per-queue
>> stats should be removed from basic stats since per-queue
>> stats should be provided by xstats API natively.
>>
>> Basically RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS means
>> that corresponding driver is not ready vs the deprecation notice.
>> So, I want to clean it up to see not yet ready drivers only.
>>
> 
> As you said, 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag set by driver means,
> driver is not ready on representing queue stats in xstats and ethdev layer is
> filling it automatically from basic stats.
> 
> First we should wait for drivers to implement it, later clean queue stats from
> basic stats and remove the flag.
> 
> I am not sure if we can remove the deprecation notice in this release, but agree
> to add a deadline for the drivers, which can be 22.11.
> 

I'm going to cleanup deprecation. I don't touch it in the
patch. I just want to cleanup list of drivers which
require attention/changes. Drivers covered here do not
provide per-queue stats in basic stats. So, there is no
point to set the flag to show it in xstats.