From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C65DAA0545 for ; Fri, 18 Nov 2022 15:04:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCCD340F18; Fri, 18 Nov 2022 15:04:52 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2057.outbound.protection.outlook.com [40.107.94.57]) by mails.dpdk.org (Postfix) with ESMTP id 18AA24003F; Fri, 18 Nov 2022 15:04:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X3I+ccDMRUffdLNG6E0z5s/BrE9pen38wGWgI68wvWoDGlVnjkiyP4kx3IBEDj0uaA4J5tS6cgulhn5g/+fRROoZpexCqo/1ClQ1F//scjFq7zpNGcWAJ0PDkW9mAZo/Cn3WhI1v+7e940y9tVRRP4gXd3KKbADVbj9dmMLiTvNWJ+12a0xya2L0ICn6Xm1wlzbq8afjllKa+/arEfp2zuiEqAoc8G3eCcd0v7osURuEaVQpUZDZOSaNE7kRssyAH3+RKkAfchw37VG65Zr3Iaou9jmWai+HnpQgwuQL69fqQqUh1RQga3btCZpT7M78Er9ODUecltXamGnVABs5pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PLH45fYPGVq1aUhkQHHxymksRzwacU1PlWM4olCZowk=; b=mq/r3OtF84lKn7bKb7Y0PYGFAke3IJEXbtswq8FGWQpE/fQP66oYGS3i9uF/zmnaMzvKl2vfhGdJVcY8Fk3yogqIVZY9FpniZNXOpopRW2dwMaiEYebhaUcLqaFgQ9Px1lOiHy9VKAEi7Dqw4UPl3sQlRBmfPI8wku85OAW3vzJagD0Wykd5ZFzx6E0KkLr219p6tsZ3UKF85W78wBE6EqrDMir1TtYor+rTLRGM8YPDp0qdWQLaY0ozrla96nUh9TvNJYTCpHEAJh+vlP9DpoKoQp5CUnqDueHq3l4rC406dWRvpY9Urx6NF2icl+waPfrSSomo4G0GJOuAYXBWmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PLH45fYPGVq1aUhkQHHxymksRzwacU1PlWM4olCZowk=; b=RNYCs+b0CHT34x/RN9zwTFenFp/eZLJ2AE+zR13Qe0e3RIp+UyNSem84GmWSnIp5g+srxFCx8ZZBuDA0gdIWBS1LBqPP+QZx49aFdgTqtgFFFuMukyg/ZKfrnD52zZBpEMVKRrgh+vaSj63BYOun2DxXD2nrFOgTFogCufLPugk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB7423.namprd12.prod.outlook.com (2603:10b6:510:229::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 14:04:48 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5813.020; Fri, 18 Nov 2022 14:04:47 +0000 Message-ID: Date: Fri, 18 Nov 2022 14:04:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, long.wu@corigine.com, stable@dpdk.org References: <20221118014408.19565-1-chaoyong.he@corigine.com> <20221118014408.19565-2-chaoyong.he@corigine.com> From: Ferruh Yigit Subject: Re: [PATCH 1/3] net/nfp: fix wrong increment of free list counter In-Reply-To: <20221118014408.19565-2-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0071.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB7423:EE_ X-MS-Office365-Filtering-Correlation-Id: dcf67957-3386-45e1-7ff7-08dac96dda1c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3FWjynlCR2Aj3PmIRDP5cQuf1GJK5R1X5QB9K0rGQk6bsuQ56A80EqG/sdZfy90RAU/RLSo4aegx8Z7qNagAkTdUzOMce83IELDSDdVp2whD6La5eNIvTZgA6mSLjBGtFZaAFKRDrhYDzXL49xbiKds5rMCzKVt7K6l2LErB5Kk7AknLWhHyJe/0m16dl5zEOGoT2BxFxVP/4ZCdHW3qYgAuc823y8LpMKKS1pHjTgVDQXmfy1EVedcBg7uG70F5H3PURCv5smEDiSmCaqghnkJpITwWf/CiiztkH+0HhXxFhd5CTFBjxNF4pB48xCqfNk2c1oC08ndG8kkGwQbNJX8dXt7KrbLbZTzQboWBs16As+q5W11RsRg0kxvVlKNBsvj+mf/UzoO0wAZzCAtRo+vSmJYNx5SK7qXA0aobt/jq2wu3/JaqF21wNDULQKnRBX995pvQ5V1fAR1GLKYSOlKQifSXMGyESMM7B4do7P1cUtIPJq0V6Jpi3q/u7U9uCHpFwmGVpoAxN1/Am/a90gcrj68oT4HCFcFdEuuLy5LEKpUhcvjLhtqjWSEqpk6RgKxCSsOhXBqZ0vhYoWj0Y0xnp7olON5jGeFMl8+Hl+mrwk4Vm2QixhlnbrwuB/kt+cFE2oFNNkoJEbH5iPMoTqvQJCRjULFWyIEwz+JrecYdBG7M+utanOmU/D6WXNDqXNF7obpZLVpSX2hBue72Ce0lJT8RKSTDa+7tqTTivnk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(39860400002)(396003)(136003)(376002)(366004)(451199015)(86362001)(31696002)(66946007)(8936002)(4744005)(2906002)(4326008)(41300700001)(44832011)(66556008)(26005)(66476007)(53546011)(6506007)(6666004)(6512007)(38100700002)(186003)(36756003)(2616005)(316002)(8676002)(478600001)(5660300002)(6486002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekxIc055Yi91TTBBUEFrb0k0QVBVNmpLblVvb2NINFJqc3U3b1ViVHVmWFYz?= =?utf-8?B?WWhqNStGQkxMUDllNGd0eG1oT2ZXcW9tVjl1bVpNZDB1Z0FmZW9sdDlXRTUz?= =?utf-8?B?OCtQYzEwVmtLMXVvRG9LSlpNNFRwSURqbGhuYWdITjBYU1E1WmRLUmZ3MERF?= =?utf-8?B?RHVueFlCTXFuN0F1cTBJM0xlM01VREROS1pPSXowdEdVMzJDZlFQQ0RtM1pG?= =?utf-8?B?R0swNXdsbW5nclg4UDVVOHd1M3F0eGFpSTF0VldiUHFEdVJPa1BhaWV6TTRH?= =?utf-8?B?OW02UjJwa3g2WFdPVzJFdXNsWkZ2aTZwcEpTbm9NemwxSDlOU2RtZWI5L2ln?= =?utf-8?B?WUdNZ3BjNUU3eEFOZTg5Y1NGdGVHekVDRFNIUlduWWIzazlXeEUvdkZPRzRl?= =?utf-8?B?NGxCMTBvSkxUNk1qdDBhUnJwaXlNdEhNVG1jSkZDbWFaTDBhcUl3RGRIVGV5?= =?utf-8?B?QXYyclZBckxUcy9iV2hqaGVMdXo1R0hwRHEwK0hlVDdjTkMzT1c0L0VuRzRF?= =?utf-8?B?eUUxUllWOVZkbCtBZjFDZzBwUU9BdExFaCswZmxRUGRLcDFJZzRjYXVJTitJ?= =?utf-8?B?Q051SkI3elNoMXFENFkrblB1QmcxTThPOUNOQlM0ZG1ITWRpa25jS1Bla2d3?= =?utf-8?B?NEMxYmpZdE1COWlWMnRidCs3WHVXNU9tQmEyNnJ5cmVQKzNOUjB5VlR6bDVi?= =?utf-8?B?a0xMVDFwRUtJdGlqZEt6eUZPMWRlQ0x2SnFtQU40RlU3eGZjR2VtZGVLYzVi?= =?utf-8?B?R2lDTnhVR0VsUTNocmZadlkvNEhNNi9KWk9DeGx3MGU3TjdJVEVqYUtwczA2?= =?utf-8?B?aTBFTnJaY29ZOEpuRzhaTVZwVHlibUtLMWlRYmRWdHJ2ZHIxNTBueFRKOU9y?= =?utf-8?B?Vnp2MEhkSUl3UVluVlVGWncvRmZqWVY1cCsyRHlsR3ZDcDNIdlhmN3oxaEQ4?= =?utf-8?B?K2ZWd0Y3WXVmaWt6NkpJUVJTWnovNDBhMndDS3hwOUZOUEdDZC9IektHUURL?= =?utf-8?B?YmxQeEgvbFkzOHBrayt4VG16RVBFdlBtTVp1N2I0YnBIK01kRkN1Z2NKTllt?= =?utf-8?B?SVMrTmRJSG1rQkRXdndQQnZlb1prYlNDL2pJUWdSNkVHb0RNVU45MzdyMktz?= =?utf-8?B?VGdFd0twOCtqUE1rSHdrd2hoNldORTU0QXB4VW9Ha2pIT1JTWVArTkJnc01H?= =?utf-8?B?bFFSR3lJVkdydFJUa2gxWmIxNjJJMHhETDdzVzhQaWoyMW1Nd3hzOEZqbkRW?= =?utf-8?B?Tm81UC9RdmNycVZGRFRoaW9yUzAyY3U5NENvV0cvOVpCNG5sbFpvcmlxUVpp?= =?utf-8?B?UVd3OWhTSEJFZ3gwV1pKMlhnaEFsZ3pBYklOdjlHeUVMZ1BTTFdRWG9nTzAv?= =?utf-8?B?TFRDMXJSd2lIUHNyVjFBT0o1TG5LMzROaFZRQ2gwY2dJZ1I4dkFWNDNqbHh1?= =?utf-8?B?UmdsMi9EUDk1NExWZ2xBaUl0WHoycnN4a0lEaHFzaENLOG43MzJwYlBRYkxt?= =?utf-8?B?NmVwL1dacWhWRE15a3JlY3ZyWHZLeGc5OHRzVzdPcGNUSWN1c1F4bmlIS0Ez?= =?utf-8?B?QTNWSHBsK2E3MVI2ZDRpa2x3dEpQelNHdi84THp4NWI2Szg0YVIrOEVKZFRh?= =?utf-8?B?dDgvblBrVzZXRUNIRnpJT256MWFaRlozbWtML2FEVElQeWFyL1M5enNzOSt6?= =?utf-8?B?OXptUUpuL3MzRVJtU0ozOVE0UXd3TmdxbXBYRGljWFZFUEl3d0VlYTJHTU1z?= =?utf-8?B?SGJzaUNrcUdPQ3NqWXRETmQvU1ZaVUdGTENhUGNtcEVxcWpMOURDSThweksz?= =?utf-8?B?ZzNtSHhRMWpNR1BPUDl1RCs5cFRlbHJmeWtSRUllOTJiYk5tV1JpelBMRTcw?= =?utf-8?B?R0d3bUo3VWNmOHZGVjZhWUhEY0JlVlYrVktmSE9xWXpTYmRVWGhJY1NHUFZV?= =?utf-8?B?akJnN0VCQmtadjFkb0VRRHpIaUthUElXOGpkbmFIMmRaOWJ3YTRlQktTR1Jh?= =?utf-8?B?V0FIVW8wRHdmeDlkS1AwSkRlRG5UakNRcHB3cGxlaUQvUGZSNGRKSVJDNmt1?= =?utf-8?B?K0NYTTFoMTM1RkNTSzFhUU5xOUZPVG55U1FqczhaSkVBd29wVTdBRXZHNFlH?= =?utf-8?Q?ChSnFqBsN14jJXBtNc7Idi9Xz?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcf67957-3386-45e1-7ff7-08dac96dda1c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 14:04:47.7077 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CPkl2vhZ4eJXg3DFjAGkhTTkgFGd+dsVsVttMea6p5nFU/y6MNJi7LhnPDm0CDP2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7423 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 11/18/2022 1:44 AM, Chaoyong He wrote: > When receiving a packet that is larger than the mbuf size, the Rx > function will break the receive loop and sent a free list descriptor > with random DMA address. > > Fix this by moving the increment of the free list descriptor counter > to after the packet size have been checked and acted on. > Issue seems one of the Rx descriptor is not rearmed properly and may have random DMA address, which can lead HW to DMA this random address, so implications can be dangerous. I suggest updating patch title slightly to highlight the impact: "net/nfp: fix Rx descriptor DMA address" > Fixes: bb340f56fcb7 ("net/nfp: fix memory leak in Rx") > Cc: long.wu@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund Series applied to dpdk-next-net/main, thanks.