From: Kevin Traynor <ktraynor@redhat.com>
To: Dekel Peled <dekelp@mellanox.com>, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 18.11] net/mlx5: block RSS action without Rx queue
Date: Tue, 7 Jan 2020 14:04:05 +0000 [thread overview]
Message-ID: <f27f828a-537e-a73b-e770-408cb07cd1c2@redhat.com> (raw)
In-Reply-To: <da611add9d44b1c6cd7245695c44e3994acb4c44.1577710730.git.dekelp@mellanox.com>
On 30/12/2019 12:59, Dekel Peled wrote:
> [ upstream commit 15c80155874e
> ("net/mlx5: block RSS action without Rx queue") ]
>
> This patch modifies function mlx5_flow_validate_action_rss(), to
> prevent the setting of rule with rss action, but without specifying
> any queues.
> For example:
> flow create 0 ingress pattern end actions rss queues end / end
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Fixed upstream commit reference format and applied. Note, this wouldn't
apply cleanly with a plain 'git am'. For future patches direct to 18.11,
please check against head of 18.11 branch.
fyi - I noticed that the 'if(!priv->rxqs_n)' check is not in 18.11 in
case you wanted to send a patch for that as well.
thanks,
Kevin.
> ---
> drivers/net/mlx5/mlx5_flow.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index f19b27e..369689c 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -943,6 +943,10 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,
> &rss->types,
> "some RSS protocols are not"
> " supported");
> + if (!rss->queue_num)
> + return rte_flow_error_set(error, EINVAL,
> + RTE_FLOW_ERROR_TYPE_ACTION_CONF,
> + NULL, "No queues configured");
> for (i = 0; i != rss->queue_num; ++i) {
> if (!(*priv->rxqs)[rss->queue[i]])
> return rte_flow_error_set
>
prev parent reply other threads:[~2020-01-07 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 12:59 Dekel Peled
2020-01-07 14:04 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f27f828a-537e-a73b-e770-408cb07cd1c2@redhat.com \
--to=ktraynor@redhat.com \
--cc=dekelp@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).