From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69E8342C07 for ; Thu, 1 Jun 2023 21:59:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 653E840FAE; Thu, 1 Jun 2023 21:59:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A8EAC40F18 for ; Thu, 1 Jun 2023 21:59:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685649588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iKLWzFiQcARm4K3rKCZaurX6g+mJpocZvffHLn//e8E=; b=RhrpL6OwRwVdtcWrzZthTqakdMiW4DetkooW/fnut+naI7TglFycO7bCffFdLxOEagbZ4D +tTWI1k0cF3T7GUnWcsdwX8VMw2RkvX9KkKOfOwY0eaqj3Eq9E+EyQb1XjZ3bs77bdf9is 8fa1ETP0l6AJu5oUyhxp81DjdfrZPgE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-581-Vt_XOSuvMZmKeTA3fnqsDw-1; Thu, 01 Jun 2023 15:59:45 -0400 X-MC-Unique: Vt_XOSuvMZmKeTA3fnqsDw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A356B185A78B; Thu, 1 Jun 2023 19:59:44 +0000 (UTC) Received: from [10.39.208.25] (unknown [10.39.208.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80BAD492B0B; Thu, 1 Jun 2023 19:59:41 +0000 (UTC) Message-ID: Date: Thu, 1 Jun 2023 21:59:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 01/28] vhost: fix missing guest notif stat increment To: dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com, mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com, cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com, eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com Cc: stable@dpdk.org References: <20230525162551.70359-1-maxime.coquelin@redhat.com> <20230525162551.70359-2-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: <20230525162551.70359-2-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 5/25/23 18:25, Maxime Coquelin wrote: > Guest notification counter was only incremented for split > ring, this patch adds it also for packed ring. > > Fixes: 1ea74efd7fa4 ("vhost: add statistics for guest notification") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin > Reviewed-by: Chenbo Xia > --- > lib/vhost/vhost.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h > index 8fdab13c70..8554ab4002 100644 > --- a/lib/vhost/vhost.h > +++ b/lib/vhost/vhost.h > @@ -973,6 +973,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struct vhost_virtqueue *vq) > kick: > if (kick) { > eventfd_write(vq->callfd, (eventfd_t)1); > + if (dev->flags & VIRTIO_DEV_STATS_ENABLED) > + vq->stats.guest_notifications++; > if (dev->notify_ops->guest_notified) > dev->notify_ops->guest_notified(dev->vid); > } Applied this single patch to dpdk-next-virtio/main, as it is needed for Eelco's series, and the rest of the VDUSE series has to be rebased on top of Eelco's. Thanks, Maxime