From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 89D373237; Tue, 26 Feb 2019 15:42:15 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E26FF30821E0; Tue, 26 Feb 2019 14:42:14 +0000 (UTC) Received: from [10.36.112.64] (ovpn-112-64.ams2.redhat.com [10.36.112.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF9205D9D1; Tue, 26 Feb 2019 14:42:09 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: stable@dpdk.org References: <20190222024209.30879-1-tiwei.bie@intel.com> <20190222024209.30879-3-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: Date: Tue, 26 Feb 2019 15:42:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190222024209.30879-3-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 26 Feb 2019 14:42:14 +0000 (UTC) Subject: Re: [dpdk-stable] [PATCH 2/4] vhost: fix potential use-after-free for zero copy mbuf X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 14:42:15 -0000 On 2/22/19 3:42 AM, Tiwei Bie wrote: > Don't free the zero copy mbufs before they have been consumed, > otherwise there could be use-after-free. > > Fixes: b0a985d1f340 ("vhost: add dequeue zero copy") > Cc:stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > lib/librte_vhost/vhost.h | 12 ++++++++++++ > lib/librte_vhost/vhost_user.c | 3 +++ > lib/librte_vhost/virtio_net.c | 12 ------------ > 3 files changed, 15 insertions(+), 12 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime