From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CBE4431FC for ; Wed, 25 Oct 2023 12:15:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D2C940DDC; Wed, 25 Oct 2023 12:15:01 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 37CD2402C5; Wed, 25 Oct 2023 12:14:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698228898; x=1729764898; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Oj98H3YDl+7c4j4KO6zZtLuree38qk/brBYJ1a+2rfQ=; b=DF/9LDRZi4Wj4bF/dtq47RhQ5tRY5iSeLIca7giBAKyNNoUGDGMP9Oin tpDJx6h5ANJICi/qPRalhl0Ya0EWpejE4f8SQYlLkS1tgji+GYSddC4cH 16stMvHM5sssiZs3CJJOk85b33i3HKk+r8lSFsOyAUAdtENVfVEpbxKQ7 PATatDTimwVYbFDTSCVGcoTT/54Hxw+8qg2bVxCqOe9sFLdw+4pWZjMKS kG/bzMnjGFfq3D0VwwKAlTqxZ5JdrD3j1+kBb1WR58VcfsEVD6k9UHVdZ Jo8T8nMTFou5esWeGlg+Y98vBHGVirxj3sDdTb5sogOxL3w5ELqtql1UN g==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="473514735" X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="473514735" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 03:14:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="829162421" X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="829162421" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Oct 2023 03:14:53 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 25 Oct 2023 03:14:52 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 25 Oct 2023 03:14:52 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 25 Oct 2023 03:14:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TJUmdktEvJRtH0o8gWmj3xU7Q5cd/DLvgDb8v6FRBCw4E4+kO9HwSZ80qKrsNB3xnvXc1UaPkrUxYq2LXNLkAu7X3Wqvyx47F6TKbKUDGzyzF8JnlAxvvs/UBp2h5uzE8aJll66oJkuWSjKQkSkf3NQvxBsMQfrEF0kpVxwLFEeHDQinpRLdNqO4fiZY92V9eN1zUZPwiYALpmjw39vNIw3oV8J0W05LNvGpF34o2ak0iFuJXC9BM9Yxpvw8dKx8wB7RwarqxY3q0fIQXVKPTfbSOyMLl6Syo3uTzgpdjhcOeWKwgL+H74sLGQr02PuLlTte0loEKxixLg2C8PsuHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MEJQ3zkEGSMeh8GK7ykpXI8YvbqTHslq2J89oV70utk=; b=LlcOsfsctEWP3pxEnWvT7q1inBR94v1PujHg9Ia8tBvw995Qm6yFn7VmSSYl2TmkOdIuPgVnYGutcx2dCPsW9gwLkjb0jy0riJ7qDaw0mrDQSBrQufmtroszge09nASCzVcNE6+uQ88rIrt1nbc3gYjgrP1SW5SX8VE47AhtpSaz1aIggdxGCwHIcB47V26IVPihrGIcu2aqDkR32GXoySQrUJyC7siIB4OTlD4cR9i3KziJcbMehx6kvsvkAQZMrq6eAXpFDg2yi9FZg6ZuGpJ+GJ25IrLVDko/Wq4yFBVDTWWDi2IzcF0gKUTOoWigv8p0tfRKYqaWTyQfiEjTTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by DM4PR11MB5247.namprd11.prod.outlook.com (2603:10b6:5:38a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Wed, 25 Oct 2023 10:14:50 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a%7]) with mapi id 15.20.6907.032; Wed, 25 Oct 2023 10:14:50 +0000 Message-ID: Date: Wed, 25 Oct 2023 11:14:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition To: David Marchand CC: "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" , "stable@dpdk.org" References: <20231024091328.11933-1-radu.nicolau@intel.com> <54859de7-c108-8389-43bc-9602a9897afc@intel.com> <59156c1c-c023-2504-6de5-6a84457e5ede@intel.com> <71a76142-86f6-729c-c0bc-4be7a41fb77a@intel.com> Content-Language: en-US From: Radu Nicolau In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DUZPR01CA0065.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c2::8) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|DM4PR11MB5247:EE_ X-MS-Office365-Filtering-Correlation-Id: 101db3dc-a8c7-4bc8-d8cb-08dbd54338c7 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qW1d9PhnuGTHw9xIHoBtOThkZRfOTz8XXBSvyZx1YABp62HW/lQajKWSirv/wPSy38cMjUjvLa8Gv9IDjC47UmXAMG6v8zKd4lYkcljCJano4Z9kylBSrm0N8KhtcdCZydMo4Y9BHKoZLSrnvQZVYJjmMpR4tJ1aMJO7yFoRzbM7NfDCKJotmXSg+/3I9DqpjIDBI3dkU2aG8lctF+VPavgvKwNqRZDdusU4uvxw0IECrhLoH2tkQu3JdtiHmoZpi08TL9TeWWIJ6Pb9bX/1DUA9g2i9Rssjmt0yfCL2aiAqWAzRGMUbC2zm4Xr4kwJ6QmMHM+AszhhJMcTPxvoIow/QOm7vThJn3YZWI7ygCXmJ6HeoaCkQ8NkWqm1irsIJT2ZzBoHDrL1sG8r6kPrqdLkQNcRCayQo3iYDEMh5tMIcudSfVGc6YioukwE84fYxRwvzmrfcZZABVTFxwCCHQ8/1Ud/+6HYk2gp6Sy1wxLUxPOoGZKxMleuKIr9FSi5NEesKPAuZ4qYn5dAD6CBuhlzC8Qzg3JcE4Hv6j9tY9NpfhnP7tQrGCJUgZDg6NZCt2uGwMLTVC0QAeAsXcqiCH+D8SkG2dwXBFwE4gz77rj6IFq21dcqX5OAVbP94zsP3YoTser4fniGRtR0olRPfZw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(396003)(366004)(136003)(39860400002)(230922051799003)(186009)(451199024)(1800799009)(64100799003)(31686004)(83380400001)(2906002)(8936002)(2616005)(5660300002)(4326008)(36756003)(8676002)(41300700001)(31696002)(86362001)(478600001)(44832011)(26005)(53546011)(38100700002)(82960400001)(55236004)(6506007)(6512007)(316002)(6666004)(6486002)(66556008)(66476007)(54906003)(6916009)(66946007)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUhmeTA1WStWYTMrMEZWYlltTyt2ZDJRcU95WWZHVXUrNjE4RGd3bXRKZGJD?= =?utf-8?B?UUJvRlUzRmRiWFNmMS9BZWVveTFjMWRCdWltVGFadVpWS2RmT2MzY2gyY2I0?= =?utf-8?B?MUs0OGMyczgyNDg5SndEU2xZM0pKRnJMRmJsbHp6U3lDRHkvTFF2OWZVR0xD?= =?utf-8?B?dGltWnpnUEg3Z3gwRHJIRVpEWmRteFNzMW9URWdIN2tWZlNWa1orN3Ayak1r?= =?utf-8?B?ODl4Ris1UVBzTXF0UVZhN2VYcDVFY29aWktuSEVxUVpSWjJ6Z0lIMnBrdDd1?= =?utf-8?B?QU9JeFovZEpYQWtadEtUM0dCSlVkcTZRN05PcXNEeXowZjlCNys5Sm5tTWpr?= =?utf-8?B?akZrK3gra0xVZkUxNFU5QnFRNm5ld0hjOHZxNFFwT2JmdGs4N1lHc1g1OWh5?= =?utf-8?B?RzFQUm53TnZNSjN4eXpsdGU5UjByRGtRSS9Sa3psNEdQOFA0U1RXZHV5elQz?= =?utf-8?B?OEY4SkcxekVNZ09Sb1RuMnNUcmFpdkFxbXpObHJiZDZSelJVQVdYSm9oRnBx?= =?utf-8?B?RWw5dkRHQnVWdG1YVGZWcXk1THhqSmxhUlVZQi90SkpRZC9jdEIxZ1pNb0h6?= =?utf-8?B?NStyNStBZHNoQlJSMUQrU2tvNXMrNkJ3c1krK25LaXE2emVFbmNIU2JSVElh?= =?utf-8?B?WjhGSmQ0VE1KcUdIOTMwQ0traThCQVFobmF5cjhaSUwxbm8wVnQveUgxMEtX?= =?utf-8?B?MmtpZmJvUlI1Yk4vQjVqc3BtRllha3pGVlpLTUNFb2NaOVRVeHljZXNEWHov?= =?utf-8?B?OU51VDFMbGIxZG93WTRFdWxzelNKczlEdUthNzh5c0NXSEd1VTB0bW5MMFl3?= =?utf-8?B?aTNXbEk1K2xBQ0ZuZTJVSVlCTzdQbk1FODhCclcrekh4UHVmaHFDNTNkWVky?= =?utf-8?B?TEdIREZVY0JiMmxvcFI3UjRCWmVpdlg0dmNoNGJXYUd5dXcwYjhkZWhjb09h?= =?utf-8?B?VXM1aFk2aWxpZExFbUt4YUtYZWdNU1lhRG56ZElySm5Jd29rSXVHN2NHeW9x?= =?utf-8?B?N1lXSi91MFIrYU5UUmo2MSs0NVB0RXU0V0x2dG1qVE1sUE1zSUNKL2N4Nmh4?= =?utf-8?B?WHZJanJNUnJjS0xXRXV2MThSSXZWKzNoU1dzeEdFTFM1aVVYeFY0NFdqWmJW?= =?utf-8?B?NHNSK2VlNE1Ld3ZDM0hDeHg3cmZEQm5IN2dTRGptWTVpMXVIUjZHMnV0bkM5?= =?utf-8?B?NnkxbVJmaHRvUXFYVUxwUzJYUzRZdmMvVjViMXhFQTVCVlNWVC8rVlpCWU1x?= =?utf-8?B?ckZiNTJuUWtmVjVwSjlUZUZYd0pDTmhVeEZUTzJKVDFlaWg1Q3hlV2hQWldT?= =?utf-8?B?L0FGT3BXcXk1REpOcmxIeTB4Z2FwT2FKYWVLTERpeVNNUUtldGJMZFJTZW9M?= =?utf-8?B?RDBkWFNKTzR4Y1NQaWE2MEFtQWVQeWFOd3JqUTdmeEM1dFcxRmtSOVdoNXdn?= =?utf-8?B?bjhtR2lvK2FaZDkwaHVWTGNmRGpRYnRBQk9NYzJuZWZ6cFRNMDh6SmdWTk1X?= =?utf-8?B?VW5NUXd4S0xOWVM1ZzZZVGxIMFo0aEh3dlBwK3A4d2JJbUJpcUpQK2RHQita?= =?utf-8?B?RmFaZG5nZkdkR2NzdC80aWJtWGpQSEYrS25aTFZJT1lrYVRPRlJ5ZnR1d3hP?= =?utf-8?B?dFdTbDlWRFFoUlVNam1oVTF3aUNHY2VFWlRiQUFDTElZdEF1cmVVYm9wR0VR?= =?utf-8?B?MGFKenVrVUx6cWFuQXNUWGNFWmFIKzR4Q0JNVy9zVW81Mmc1cFMyKzNWZml0?= =?utf-8?B?OWFoNGErM3JlVTg4QWpqYytGWEg1aEhZQzd2b3NpcjF6a0l0bUtMTmsrdWlh?= =?utf-8?B?bW5Xc1ZxR3pNMkhKdVdZTy93aFVnY3ZmNDc1eXFlV2k0Q0VURUlvWkMxbkdB?= =?utf-8?B?WExVMFBPQklwRUNiNDN4Y3N3YlpsK01FL2NGZTFpTHUxSXd3NStZUVpRL0h1?= =?utf-8?B?dldXVE5ZcENxRkFBeFdtUGFqV0F4Vm45TjVObVgvY3BUckx1ZlQ0eURPZ1ND?= =?utf-8?B?bmw2Vk1FaVR3dlF4anpwQStiS0Z0M2ZmUUc0ZnIzbTVDYytqb3JObUV1emY2?= =?utf-8?B?b0REWWZwaEUzVUFZd1FnVkNEdHVQMlZRQUNaY3pzQkVVM1Q3Mm5hZW8wZWlE?= =?utf-8?B?dm1JTHFpSHUzRFpXcUhHS3pnVG5aWEtvM2U2dVJ5WjltUTQ0YWV5ZW5CM0c4?= =?utf-8?B?ZkE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 101db3dc-a8c7-4bc8-d8cb-08dbd54338c7 X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 10:14:49.7451 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DK6WFT0Mhek7/0WS+FMgZgLVEils5kBgDXYPXTU4xoBrjWwpcKUxzO2ULRsLMzCyoJKDGllc+JfeEPTAuuIxCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5247 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 25-Oct-23 10:07 AM, David Marchand wrote: > On Wed, Oct 25, 2023 at 11:02 AM Radu Nicolau wrote: >> >> On 25-Oct-23 12:30 AM, Zhang, Qi Z wrote: >>>> -----Original Message----- >>>> From: Nicolau, Radu >>>> Sent: Tuesday, October 24, 2023 10:49 PM >>>> To: Zhang, Qi Z ; Marchand, David >>>> >>>> Cc: Wu, Jingjing ; Xing, Beilei ; >>>> dev@dpdk.org; stable@dpdk.org >>>> Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition >>>> >>>> >>>> On 24-Oct-23 12:24 PM, Zhang, Qi Z wrote: >>>>>> -----Original Message----- >>>>>> From: Radu Nicolau >>>>>> Sent: Tuesday, October 24, 2023 6:23 PM >>>>>> To: Marchand, David >>>>>> Cc: Wu, Jingjing ; Xing, Beilei >>>>>> ; dev@dpdk.org; stable@dpdk.org >>>>>> Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition >>>>>> >>>>>> >>>>>> On 24-Oct-23 10:49 AM, David Marchand wrote: >>>>>>> On Tue, Oct 24, 2023 at 11:13 AM Radu Nicolau >>>>>>> >>>>>> wrote: >>>>>>>> IAVF_TX_OFFLOAD_MASK definition contained >>>>>> RTE_ETH_TX_OFFLOAD_SECURITY >>>>>>>> instead of RTE_MBUF_F_TX_SEC_OFFLOAD. >>>>>>>> >>>>>>>> Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") >>>>>>>> Cc: stable@dpdk.org >>>>>>>> >>>>>>>> Signed-off-by: Radu Nicolau >>>>>>> Something is not clear to me. >>>>>>> How was the IPsec inline crypto feature supposed to work with this >>>>>>> driver so far? >>>>>>> >>>>>>> Any packet with the RTE_MBUF_F_TX_SEC_OFFLOAD flag should have >>>> been >>>>>>> refused in iavf_prep_pkts. >>>>>>> >>>>>> It worked because the IPsec sample app doesn't call >>>>>> rte_eth_tx_prepare, and from what I can see no other sample app does. >>>>> To keep consistent, its better to refine the >>>> IAVF_TX_OFFLOAD_NOTSUP_MASK definition. >>>> >>>> You mean like this? >>>> >>>> >>>> #define IAVF_TX_OFFLOAD_NOTSUP_MASK ( \ >>>> RTE_MBUF_F_TX_OFFLOAD_MASK ^ ( \ >>>> RTE_MBUF_F_TX_OUTER_IPV6 | \ >>>> RTE_MBUF_F_TX_OUTER_IPV4 | \ >>>> RTE_MBUF_F_TX_IPV6 | \ >>>> RTE_MBUF_F_TX_IPV4 | \ >>>> RTE_MBUF_F_TX_VLAN | \ >>>> RTE_MBUF_F_TX_IP_CKSUM | \ >>>> RTE_MBUF_F_TX_L4_MASK | \ >>>> RTE_MBUF_F_TX_TCP_SEG | \ >>>> RTE_MBUF_F_TX_UDP_SEG | \ >>>> RTE_MBUF_F_TX_TUNNEL_MASK | \ >>>> RTE_MBUF_F_TX_OUTER_IP_CKSUM | \ >>>> RTE_MBUF_F_TX_OUTER_UDP_CKSUM | \ >>>> RTE_MBUF_F_TX_SEC_OFFLOAD)) >>> Sorry, I miss understanding this code change, actually you didn't remove a flag, but just replace it, NOTSUP_MASK no need to be changed >>> >>> Then I don't understand why "Any packet with the RTE_MBUF_F_TX_SEC_OFFLOAD flag should have refused in iavf_prep_pkts" >>> But I assume tx_pkt_prepare should reject only invalid packets while still functioning correctly with inline IPsec. >> rte_eth_tx_prepare would have rejected the packets before this fix, but >> no app calls rte_eth_tx_prepare. The only app that calls it is testpmd. > From my understanding, applications that want checksum offload are > required to call rte_eth_tx_prepare. TBH I don't understand much about it and looking at the implementation actually made things worse: for example from what I can see calling it when RTE_MBUF_F_TX_TCP_CKSUM is set will result in having the TCP checksum being computed (in software) in the prepare function.