patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Xiaolong Ye <xiaolong.ye@intel.com>,
	Tiwei Bie <tiwei.bie@intel.com>,
	Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v1 1/2] net/virtio: fix for out of date comment
Date: Thu, 9 Apr 2020 16:20:24 +0200
Message-ID: <f6dee126-e9d6-2e8b-c07e-8607efe5c282@redhat.com> (raw)
In-Reply-To: <20200307132235.210168-2-xiaolong.ye@intel.com>



On 3/7/20 2:22 PM, Xiaolong Ye wrote:
> Fix the comment that's incorrect as the code evolves.
> 
> Fixes: 9470427c88e1 ("net/virtio: do not store PCI device pointer at shared memory")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index f9d0ea70d..35203940a 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -466,7 +466,7 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)
>  	}
>  
>  	if (!vtpci_packed_queue(hw) && !rte_is_power_of_2(vq_size)) {
> -		PMD_INIT_LOG(ERR, "split virtqueue size is not powerof 2");
> +		PMD_INIT_LOG(ERR, "split virtqueue size is not power of 2");
>  		return -EINVAL;
>  	}
>  
> @@ -588,8 +588,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)
>  		hw->cvq = cvq;
>  	}
>  
> -	/* For virtio_user case (that is when hw->dev is NULL), we use
> -	 * virtual address. And we need properly set _offset_, please see
> +	/* For virtio_user case (that is when hw->virtio_user_dev is not NULL),
> +	 * we use virtual address. And we need properly set _offset_, please see
>  	 * VIRTIO_MBUF_DATA_DMA_ADDR in virtqueue.h for more information.
>  	 */
>  	if (!hw->virtio_user_dev)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2020-04-09 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200307132235.210168-1-xiaolong.ye@intel.com>
2020-03-07 13:22 ` Xiaolong Ye
2020-04-09 14:20   ` Maxime Coquelin [this message]
2020-03-07 13:22 ` [dpdk-stable] [PATCH v1 2/2] vhost: remove unused variable Xiaolong Ye
2020-04-09 14:21   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6dee126-e9d6-2e8b-c07e-8607efe5c282@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    --cc=xiaolong.ye@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git