From: Aaron Conole <aconole@redhat.com>
To: Pallantla Poornima <pallantlax.poornima@intel.com>
Cc: dev@dpdk.org, reshma.pattan@intel.com, ferruh.yigit@intel.com,
bruce.richardson@intel.com, stephen@networkplumber.org,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] app/test: fix sprintf with strlcat
Date: Wed, 13 Mar 2019 09:51:29 -0400 [thread overview]
Message-ID: <f7t5zsmrify.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <1552475243-16215-1-git-send-email-pallantlax.poornima@intel.com> (Pallantla Poornima's message of "Wed, 13 Mar 2019 11:07:23 +0000")
Pallantla Poornima <pallantlax.poornima@intel.com> writes:
> sprintf function is not secure as it doesn't check the length of string.
> More secure function strlcat is used.
>
> Fixes: 727909c592 ("app/test: introduce dynamic commands list")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> ---
> v2: Used strlcat to avoid buffer overflow.
> ---
LGTM.
Reviewed-by: Aaron Conole <aconole@redhat.com>
next prev parent reply other threads:[~2019-03-13 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 11:07 Pallantla Poornima
2019-03-13 13:51 ` Aaron Conole [this message]
2019-04-02 0:37 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t5zsmrify.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pallantlax.poornima@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).