From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BDEBF4C8E; Wed, 13 Mar 2019 14:51:31 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 16FAE30E92FA; Wed, 13 Mar 2019 13:51:31 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 40CC01001E80; Wed, 13 Mar 2019 13:51:30 +0000 (UTC) From: Aaron Conole To: Pallantla Poornima Cc: dev@dpdk.org, reshma.pattan@intel.com, ferruh.yigit@intel.com, bruce.richardson@intel.com, stephen@networkplumber.org, stable@dpdk.org References: <1552475243-16215-1-git-send-email-pallantlax.poornima@intel.com> Date: Wed, 13 Mar 2019 09:51:29 -0400 In-Reply-To: <1552475243-16215-1-git-send-email-pallantlax.poornima@intel.com> (Pallantla Poornima's message of "Wed, 13 Mar 2019 11:07:23 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 13 Mar 2019 13:51:31 +0000 (UTC) Subject: Re: [dpdk-stable] [PATCH v2] app/test: fix sprintf with strlcat X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 13:51:32 -0000 Pallantla Poornima writes: > sprintf function is not secure as it doesn't check the length of string. > More secure function strlcat is used. > > Fixes: 727909c592 ("app/test: introduce dynamic commands list") > Cc: stable@dpdk.org > > Signed-off-by: Pallantla Poornima > --- > v2: Used strlcat to avoid buffer overflow. > --- LGTM. Reviewed-by: Aaron Conole