From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 47ACCA00E6 for ; Mon, 10 Jun 2019 14:10:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A9DB1C035; Mon, 10 Jun 2019 14:10:20 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9AD911BFB9; Mon, 10 Jun 2019 14:10:16 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 967BE3087930; Mon, 10 Jun 2019 12:10:12 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9EBD060925; Mon, 10 Jun 2019 12:10:10 +0000 (UTC) From: Aaron Conole To: Cc: , , , , , In-Reply-To: <20190606145054.39995-1-jerinj@marvell.com> (jerinj@marvell.com's message of "Thu, 6 Jun 2019 20:20:54 +0530") References: <20190606145054.39995-1-jerinj@marvell.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Mon, 10 Jun 2019 08:10:09 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 10 Jun 2019 12:10:15 +0000 (UTC) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" writes: > From: Jerin Jacob > > Some compilers reporting the following error, though the existing > code doesn't have any uninitialized variable case. > Just to make compiler happy, initialize the int32x4_t variable > one shot in C language. > > ../lib/librte_acl/acl_run_neon.h: In function 'search_neon_4' > ../lib/librte_acl/acl_run_neon.h:230:12: error: 'input' may be > used uninitialized in this function [-Werror=maybe-uninitialized] > int32x4_t input; > > Fixes: 34fa6c27c156 ("acl: add NEON optimization for ARMv8") > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob > --- This pattern is easy to understand, congruent with other usages in the code base, has good patch statistics, and solves the issue. Acked-by: Aaron Conole I prefer this solution to the others posted. Thanks for looking into it, Jerin!