From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA03FA3295 for ; Wed, 23 Oct 2019 17:17:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B56221C2F9; Wed, 23 Oct 2019 17:17:32 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 4F22A1C2F9 for ; Wed, 23 Oct 2019 17:17:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571843850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q+Kf3uSzQhc3tiS5ZhiBxqGKJCcq4TRG3xYG8DWtwLU=; b=DWEkcfwKn9sLIHdnDFwga99d5UKANB8dyL0qlSumTy07Iy22EPTzGJZU1mKaqU0R5tUc2I NASrV3yOxyD2PNg3xFRX0amW44L3xJwRDAuKzgja7+Kc64JY0QKSFquDWiK47q5reSYfs9 JfdY1cvHTlgrqrW9yRzeqZNlufRMNt0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-7-K-V7SMvBPQW9X61nWKzzgQ-1; Wed, 23 Oct 2019 11:17:09 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5261D1800E17; Wed, 23 Oct 2019 15:17:08 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F0D01001DC2; Wed, 23 Oct 2019 15:17:00 +0000 (UTC) From: Aaron Conole To: Pavan Nikhilesh Bhagavatula Cc: David Marchand , Jerin Jacob Kollanukkaran , Stephen Hemminger , dev , dpdk stable References: Date: Wed, 23 Oct 2019 11:16:59 -0400 In-Reply-To: (Pavan Nikhilesh Bhagavatula's message of "Wed, 23 Oct 2019 15:06:48 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: K-V7SMvBPQW9X61nWKzzgQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Pavan Nikhilesh Bhagavatula writes: >>Pavan Nikhilesh Bhagavatula writes: >> >>>>> > >>>>> >Any review? >>>>> > >>>>> >Are we missing an update in the unit test to catch this issue? >>>>> >Thanks. >>>>> >>>>> We actually caught it in a unit test >>>>> >test_reciprocal_division >>>> >>>>We had this problem since the very start then. >>>> >>>>Both reciprocal_division and reciprocal_division_perf are in the >>"perf" >>>>list. >>>>Can they be promoted to the standard list? >>> >>> Both of these tests take >=3D5 min depending on the platform in use >>which is why >>> they are placed in perf tests. >> >>Is it possible to write a smaller set of tests that can be put in the >>standard list? >> > > Currently we have MAX_ITERATIONS (1ULL << 32) for both the tests > maybe we can reduce it to 1 << 16 for the normal case? Sounds good to me. If you submit a patch, we can look at the run time from the robot submission as well. >>>> >>>> >>>>-- >>>>David Marchand