From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 52A3A25D9 for ; Thu, 26 Jul 2018 11:50:56 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id DD7F9B40068; Thu, 26 Jul 2018 09:50:54 +0000 (UTC) Received: from [192.168.1.16] (85.187.13.33) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 26 Jul 2018 10:50:49 +0100 To: Luca Boccassi , Andrew Rybchenko CC: References: <1531302380-16764-1-git-send-email-arybchenko@solarflare.com> <1532365849.7624.12.camel@debian.org> <4de7a434-ea9f-8f0c-fd11-6b3c6419ad7c@solarflare.com> <1532598414.20916.22.camel@debian.org> From: Andrew Rybchenko Message-ID: Date: Thu, 26 Jul 2018 12:50:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1532598414.20916.22.camel@debian.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [85.187.13.33] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-23992.003 X-TM-AS-Result: No-12.967400-8.000000-10 X-TMASE-MatchedRID: zGP2F0O7j/uUwUqKnW+CICa1MaKuob8PC/ExpXrHizwAhmnHHeGnva4T oUk/aSm1IV4u8YKdeKu9P+yS8ovAWGFo+3MesZg6U+OjsPhIWDj4qCLIu0mtIKj5v7I4/SgYKpG x84vlLTRY+XGpfmaXLN6Mgp6awywN675rKjRKYc2prpImTnz4tjhaxI2If9ReklUBC796GDpsXW ARLHBnG30BZDn6zZo/XZq9SdL5Mn0M8jMXjBF+sIMbH85DUZXyseWplitmp0j6C0ePs7A07R/88 i/oAaosuJx+4T9hsuvFcDS77icyEiDXJGprGXf6euUpIc7egXc= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--12.967400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-23992.003 X-MDID: 1532598655-4es5v5Wowibd Subject: Re: [dpdk-stable] [PATCH] net/sfc: cut non VLAN ID bits from TCI X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 09:50:56 -0000 On 26.07.2018 12:46, Luca Boccassi wrote: > On Thu, 2018-07-26 at 12:42 +0300, Andrew Rybchenko wrote: >> On 23.07.2018 20:10, Luca Boccassi wrote: >>> On Wed, 2018-07-11 at 10:46 +0100, Andrew Rybchenko wrote: >>>> TCI may contain PCP or DEI bits. Matching of these bits is not >>>> supported, but the bits still may be set in specification value >>>> and >>>> not covered by mask. So, these bits should be ignored. >>>> >>>> Fixes: 894080975e1e ("net/sfc: support VLAN in flow API filters") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Andrew Rybchenko >>>> Reviewed-by: Roman Zhukov >>>> --- >>>>   drivers/net/sfc/sfc_flow.c | 3 ++- >>>>   1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/sfc/sfc_flow.c >>>> b/drivers/net/sfc/sfc_flow.c >>>> index 5613d59a9..18387415e 100644 >>>> --- a/drivers/net/sfc/sfc_flow.c >>>> +++ b/drivers/net/sfc/sfc_flow.c >>>> @@ -371,7 +371,8 @@ sfc_flow_parse_vlan(const struct >>>> rte_flow_item >>>> *item, >>>>     * the outer tag and the next matches the inner tag. >>>>     */ >>>>    if (mask->tci == supp_mask.tci) { >>>> - vid = rte_bswap16(spec->tci); >>>> + /* Apply mask to keep VID only */ >>>> + vid = rte_bswap16(spec->tci & mask->tci); >>>> >>>>    if (!(efx_spec->efs_match_flags & >>>>          EFX_FILTER_MATCH_OUTER_VID)) { >>> Hi Andrew, >>> >>> For which stable release branch is this patch intended? Has it (or >>> an >>> equivalent) been merged into mainline? >> Hi Luka, >> >> Yes, the patch is applied in mainline [1]. >> >> It would be good if it is applied to 17.11, 18.02 and 18.05 stable >> branches. >> >> [1] >> https://git.dpdk.org/dpdk/commit/?id=8028142107a858a146bfdbaa010b7e77 >> ff987342 >> >> Thanks, >> Andrew. > Ok, thanks, in the future please use --subject-prefix='PATCH xx.yy' > with git send-email to indicate the target branch(es) Sorry, but I'm not sure that I understand. It was a fix to mainline which should be applied to stable branches as well. As I understand PATCH xx.yy is applicable only when it is a dedicated patch to stable release. Am I missing something? Andrew.