patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Kevin Traynor <ktraynor@redhat.com>, stable@dpdk.org
Cc: xuan.ding@intel.com
Subject: Re: [dpdk-stable] [PATCH 19.11] vhost: remove zero-copy and client mode restriction
Date: Wed, 01 Jul 2020 16:09:16 +0100	[thread overview]
Message-ID: <f94222e2b126f737f020d03b9a47875cc415b0a6.camel@debian.org> (raw)
In-Reply-To: <20200701135305.20343-1-ktraynor@redhat.com>

On Wed, 2020-07-01 at 14:53 +0100, Kevin Traynor wrote:
> Commits [1] were backported as fixes from the latest DPDK release
> to the stable branches. They are detecting if vhost-user client and
> zero-copy are being used together. As this can be problematic in
> some cases, this combination was being rejected by those patches.
> 
> It might be ok to deprecate this combination in latest DPDK,
> but for stable releases we should not remove the functionality
> as it may be in use with earlier releases from the same stable branch.
> 
> In fact, we know that this functionality is used at least in OVS in
> multiple releases/active branches.
> 
> This patch removes the restriction of zero-copy and client mode
> and adds a warning for the user.
> 
> [1]
> commit a6ae060e3995
> ("vhost: prevent zero-copy with incompatible client mode")
> 
> commit 1c2eaf9a9852
> ("vhost: fix zero-copy server mode")
> 
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> Cc: xuan.ding@intel.com
> Cc: bluca@debian.org
> ---
>  lib/librte_vhost/socket.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index 2461549fea..dc3ee1e99d 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -927,10 +927,8 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
>  			goto out_mutex;
>  		}
> -		if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
> -			RTE_LOG(ERR, VHOST_CONFIG,
> -			"error: zero copy is incompatible with vhost client mode\n");
> -			ret = -1;
> -			goto out_mutex;
> -		}
> +		if ((flags & RTE_VHOST_USER_CLIENT) != 0)
> +			RTE_LOG(WARNING, VHOST_CONFIG,
> +			"zero copy may be incompatible with vhost client mode\n");
> +
>  		vsocket->supported_features &= ~(1ULL << VIRTIO_F_IN_ORDER);
>  		vsocket->features &= ~(1ULL << VIRTIO_F_IN_ORDER);

Acked-by: Luca Boccassi <bluca@debian.org>

Thanks, applied.

-- 
Kind regards,
Luca Boccassi

      reply	other threads:[~2020-07-01 15:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 13:53 Kevin Traynor
2020-07-01 15:09 ` Luca Boccassi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f94222e2b126f737f020d03b9a47875cc415b0a6.camel@debian.org \
    --to=bluca@debian.org \
    --cc=ktraynor@redhat.com \
    --cc=stable@dpdk.org \
    --cc=xuan.ding@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).