From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5428A0350 for ; Wed, 1 Jul 2020 17:09:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86E1D1C1BB; Wed, 1 Jul 2020 17:09:19 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 804F01C1BB for ; Wed, 1 Jul 2020 17:09:18 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id r12so24257427wrj.13 for ; Wed, 01 Jul 2020 08:09:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=a+GeqdBHB/rwIq/ppLlfdJjGqCvLmMF2sDahdgoHwF0=; b=dkbTdH7LZS/T+oVzvVQecFnhxQ9PxXgzCklvmP9zOJKJ7QxSTIzCXS7N2hRRcB+Bzh 2/CmOICi8IJqWV6W7tCwLv5Yb/oGu2We33griqljgZiAKdSxtk5ukMl7HjzcZTBSM52G 3uUIuRUzNOw+v0PuL+uwsXWefNa8Saq8mBoUJOC1NW6A3Hnsyi7HUEpRCLsCGg7hOvdB b+6TKx+ArfCvYgziidweXL2tfWZHUVgoDvoyCaGlmVR7N30HeD+3+j2M3MX05DEv8DZ6 858jhEBQsbpBtE+hMrwu19xGOJK4Mmfu5qEVBA487OI+Rdmez6KrndcNFvFKfGkBLehv AGCQ== X-Gm-Message-State: AOAM5314KFkTFy9y3Ahfb6YXaxxnjA1LtoizB13ROdrRFdKVprnmya+D tFR3iIDn3LOR9EuNvCjWFYw= X-Google-Smtp-Source: ABdhPJxErsaDDZvyQp8h8U5FteH+jJH4jiP9+XGkm3rQifYKcdxAN7W1zQoP9/6O2QaYggIzs9rUXg== X-Received: by 2002:adf:c441:: with SMTP id a1mr26813044wrg.130.1593616158221; Wed, 01 Jul 2020 08:09:18 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id p25sm7184031wmg.39.2020.07.01.08.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 08:09:17 -0700 (PDT) Message-ID: From: Luca Boccassi To: Kevin Traynor , stable@dpdk.org Cc: xuan.ding@intel.com Date: Wed, 01 Jul 2020 16:09:16 +0100 In-Reply-To: <20200701135305.20343-1-ktraynor@redhat.com> References: <20200701135305.20343-1-ktraynor@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 19.11] vhost: remove zero-copy and client mode restriction X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, 2020-07-01 at 14:53 +0100, Kevin Traynor wrote: > Commits [1] were backported as fixes from the latest DPDK release > to the stable branches. They are detecting if vhost-user client and > zero-copy are being used together. As this can be problematic in > some cases, this combination was being rejected by those patches. >=20 > It might be ok to deprecate this combination in latest DPDK, > but for stable releases we should not remove the functionality > as it may be in use with earlier releases from the same stable branch. >=20 > In fact, we know that this functionality is used at least in OVS in > multiple releases/active branches. >=20 > This patch removes the restriction of zero-copy and client mode > and adds a warning for the user. >=20 > [1] > commit a6ae060e3995 > ("vhost: prevent zero-copy with incompatible client mode") >=20 > commit 1c2eaf9a9852 > ("vhost: fix zero-copy server mode") >=20 > Signed-off-by: Kevin Traynor > --- > Cc: xuan.ding@intel.com > Cc: bluca@debian.org > --- > lib/librte_vhost/socket.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c > index 2461549fea..dc3ee1e99d 100644 > --- a/lib/librte_vhost/socket.c > +++ b/lib/librte_vhost/socket.c > @@ -927,10 +927,8 @@ rte_vhost_driver_register(const char *path, uint64_t= flags) > goto out_mutex; > } > - if ((flags & RTE_VHOST_USER_CLIENT) !=3D 0) { > - RTE_LOG(ERR, VHOST_CONFIG, > - "error: zero copy is incompatible with vhost client mode\n"); > - ret =3D -1; > - goto out_mutex; > - } > + if ((flags & RTE_VHOST_USER_CLIENT) !=3D 0) > + RTE_LOG(WARNING, VHOST_CONFIG, > + "zero copy may be incompatible with vhost client mode\n"); > + > vsocket->supported_features &=3D ~(1ULL << VIRTIO_F_IN_ORDER); > vsocket->features &=3D ~(1ULL << VIRTIO_F_IN_ORDER); Acked-by: Luca Boccassi Thanks, applied. --=20 Kind regards, Luca Boccassi