From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFB3541B8D for ; Tue, 31 Jan 2023 10:20:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A740640EF0; Tue, 31 Jan 2023 10:20:43 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D334340DFB for ; Tue, 31 Jan 2023 10:20:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675156838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VRbXM3iHjwS0z9j0+QvBWvbYZSd47wMTFqsGAwgL4I8=; b=gfIFpp0SehvtWp5puAw6gLRujyqyQAxxJQv+kuYkXjB6+vAKE18Le2wElQ5KdKb7WSdMAH JQX8ngCRujjcYQe08UGKEn/iSBratH7fgH6sgLNiXp3xzoV1VVqDZZcyGuGaySYNU0+eg9 6xW8Sq0cL2HTWGxnRr6SGvFlThwfjWg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-245-6_eDdYZGPv-JY0ZIauymQQ-1; Tue, 31 Jan 2023 04:20:37 -0500 X-MC-Unique: 6_eDdYZGPv-JY0ZIauymQQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4C26E18A6462; Tue, 31 Jan 2023 09:20:33 +0000 (UTC) Received: from [10.39.208.22] (unknown [10.39.208.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8AB90C15BAD; Tue, 31 Jan 2023 09:20:30 +0000 (UTC) Message-ID: Date: Tue, 31 Jan 2023 10:20:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v1 01/13] test/bbdev: fix seg fault for non supported HARQ len To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20230117165023.20567-1-hernan.vargas@intel.com> <20230117165023.20567-2-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230117165023.20567-2-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Hernan, On 1/17/23 17:50, Hernan Vargas wrote: > Catching a corner in bbdev-test (not in the actual PMD) when running > some specific vectors which size are not supported by the PMD. Could you please reword the commit message, the title is clearer than the commit message itself. Also, the app name is test-bbdev. > > Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/test_bbdev_perf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 3818b74c79..cc7b5481d6 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -84,7 +84,7 @@ > /* Increment for next code block in external HARQ memory */ > #define HARQ_INCR 32768 > /* Headroom for filler LLRs insertion in HARQ buffer */ > -#define FILLER_HEADROOM 1024 > +#define FILLER_HEADROOM 2048 > /* Constants from K0 computation from 3GPP 38.212 Table 5.4.2.1-2 */ > #define N_ZC_1 66 /* N = 66 Zc for BG 1 */ > #define N_ZC_2 50 /* N = 50 Zc for BG 2 */ > @@ -2111,9 +2111,9 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, > ops_ld->n_filler; > if (data_len > deRmOutSize) > data_len = deRmOutSize; > - if (data_len > orig_op->segments[i].length) > - data_len = orig_op->segments[i].length; > } > + if (data_len > orig_op->segments[i].length) > + data_len = orig_op->segments[i].length; > /* > * HARQ output can have minor differences > * due to integer representation and related scaling