* [PATCH v1 01/13] test/bbdev: fix seg fault for non supported HARQ len [not found] <20230117165023.20567-1-hernan.vargas@intel.com> @ 2023-01-17 16:50 ` Hernan Vargas 2023-01-31 9:20 ` Maxime Coquelin 0 siblings, 1 reply; 2+ messages in thread From: Hernan Vargas @ 2023-01-17 16:50 UTC (permalink / raw) To: dev, maxime.coquelin, gakhil, trix Cc: nicolas.chautru, qi.z.zhang, Hernan Vargas, stable Catching a corner in bbdev-test (not in the actual PMD) when running some specific vectors which size are not supported by the PMD. Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") Cc: stable@dpdk.org Signed-off-by: Hernan Vargas <hernan.vargas@intel.com> --- app/test-bbdev/test_bbdev_perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 3818b74c79..cc7b5481d6 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -84,7 +84,7 @@ /* Increment for next code block in external HARQ memory */ #define HARQ_INCR 32768 /* Headroom for filler LLRs insertion in HARQ buffer */ -#define FILLER_HEADROOM 1024 +#define FILLER_HEADROOM 2048 /* Constants from K0 computation from 3GPP 38.212 Table 5.4.2.1-2 */ #define N_ZC_1 66 /* N = 66 Zc for BG 1 */ #define N_ZC_2 50 /* N = 50 Zc for BG 2 */ @@ -2111,9 +2111,9 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, ops_ld->n_filler; if (data_len > deRmOutSize) data_len = deRmOutSize; - if (data_len > orig_op->segments[i].length) - data_len = orig_op->segments[i].length; } + if (data_len > orig_op->segments[i].length) + data_len = orig_op->segments[i].length; /* * HARQ output can have minor differences * due to integer representation and related scaling -- 2.37.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1 01/13] test/bbdev: fix seg fault for non supported HARQ len 2023-01-17 16:50 ` [PATCH v1 01/13] test/bbdev: fix seg fault for non supported HARQ len Hernan Vargas @ 2023-01-31 9:20 ` Maxime Coquelin 0 siblings, 0 replies; 2+ messages in thread From: Maxime Coquelin @ 2023-01-31 9:20 UTC (permalink / raw) To: Hernan Vargas, dev, gakhil, trix; +Cc: nicolas.chautru, qi.z.zhang, stable Hi Hernan, On 1/17/23 17:50, Hernan Vargas wrote: > Catching a corner in bbdev-test (not in the actual PMD) when running > some specific vectors which size are not supported by the PMD. Could you please reword the commit message, the title is clearer than the commit message itself. Also, the app name is test-bbdev. > > Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas <hernan.vargas@intel.com> > --- > app/test-bbdev/test_bbdev_perf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 3818b74c79..cc7b5481d6 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -84,7 +84,7 @@ > /* Increment for next code block in external HARQ memory */ > #define HARQ_INCR 32768 > /* Headroom for filler LLRs insertion in HARQ buffer */ > -#define FILLER_HEADROOM 1024 > +#define FILLER_HEADROOM 2048 > /* Constants from K0 computation from 3GPP 38.212 Table 5.4.2.1-2 */ > #define N_ZC_1 66 /* N = 66 Zc for BG 1 */ > #define N_ZC_2 50 /* N = 50 Zc for BG 2 */ > @@ -2111,9 +2111,9 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, > ops_ld->n_filler; > if (data_len > deRmOutSize) > data_len = deRmOutSize; > - if (data_len > orig_op->segments[i].length) > - data_len = orig_op->segments[i].length; > } > + if (data_len > orig_op->segments[i].length) > + data_len = orig_op->segments[i].length; > /* > * HARQ output can have minor differences > * due to integer representation and related scaling ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-31 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230117165023.20567-1-hernan.vargas@intel.com>
2023-01-17 16:50 ` [PATCH v1 01/13] test/bbdev: fix seg fault for non supported HARQ len Hernan Vargas
2023-01-31 9:20 ` Maxime Coquelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).