From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35C84A0521 for ; Wed, 4 Nov 2020 10:40:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 081E9C8B4; Wed, 4 Nov 2020 10:40:44 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8700FC86C; Wed, 4 Nov 2020 10:40:39 +0100 (CET) IronPort-SDR: TEcOpcwXb3hEAQCzD33tDcQaz92/QW9kA+CPgDBs4vQDwwHCnX5EJxvS1CoIVmxgpifmGJgNTR hBVFJzgatqSg== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="166601591" X-IronPort-AV: E=Sophos;i="5.77,450,1596524400"; d="scan'208";a="166601591" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 01:40:37 -0800 IronPort-SDR: gVyn4Nqu2CzRYZeJbCztWASxRgLbqFOBs0LofF84dV/9lbBsktkvvIvtF1RUHcRa4SHVBQa5iS ak9gjoikT1Rg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,450,1596524400"; d="scan'208";a="471148057" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 04 Nov 2020 01:40:36 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 4 Nov 2020 01:40:35 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 4 Nov 2020 17:40:34 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Wed, 4 Nov 2020 17:40:34 +0800 From: "Guo, Jia" To: "Di, ChenxuX" , "dev@dpdk.org" CC: "Xing, Beilei" , "Wang, Haiyue" , "Di, ChenxuX" , "stable@dpdk.org" Thread-Topic: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask Thread-Index: AQHWsoa+r4sfu4hglkatAitk/wo/ZKm3tFfg Date: Wed, 4 Nov 2020 09:40:33 +0000 Message-ID: References: <20201104082959.63800-1-chenxux.di@intel.com> <20201104082959.63800-2-chenxux.di@intel.com> In-Reply-To: <20201104082959.63800-2-chenxux.di@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, chenxu > -----Original Message----- > From: Chenxu Di > Sent: Wednesday, November 4, 2020 4:30 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; W= ang, > Haiyue ; Di, ChenxuX ; > stable@dpdk.org > Subject: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask >=20 > The register of FDIR flex mask should not be set during flow validate. > It should be set when flow create. >=20 > Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for FDIR= ") Seems that you move the place of flexible payload parsing from flow validat= e to create, you delete something but miss some useless parameter deleting, such as " off_arr/len_arr" etc in this [PATCH 1/2] or [PATCH 2/3]. Please d= ouble check if anything related remove and if you want you could merge into= 1 remove patch if it could be. > Cc: stable@dpdk.org >=20 > Signed-off-by: Chenxu Di > --- > drivers/net/i40e/i40e_ethdev.h | 1 + > drivers/net/i40e/i40e_fdir.c | 94 ++++++++++++++++++++++++++++++++ > drivers/net/i40e/i40e_flow.c | 97 +--------------------------------- > 3 files changed, 97 insertions(+), 95 deletions(-) >=20 <...>