patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: <vipul.ashri@oracle.com>, <grive@u256.net>
Cc: <stable@dpdk.org>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: link_update request crashing at boot
Date: Mon, 22 Nov 2021 09:36:23 +0000	[thread overview]
Message-ID: <fde70266-b79c-d64c-79ea-ab731c4cfaf4@intel.com> (raw)
In-Reply-To: <20211021214215.1633-1-vipul.ashri@oracle.com>

On 10/21/2021 10:42 PM, vipul.ashri@oracle.com wrote:
> From: Vipul Ashri <vipul.ashri@oracle.com>
> 
> failsafe crashed while sending early link_update request during
> boot time initialization.
> Based on debugging we found failsafe device was good but sub-
> devices were progressing towards initialization and SUBOPS macro
> where expanding macro gives [partial_dev]->dev_ops->link_update()
> execution of which triggered crash because dev_ops==0. similar
> crash seen at failsafe_eth_dev_close()
> 
> Failsafe driver need a separate check for subdevices similar to
> "RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);" which is
> called to almost every eth_dev function.
> 
> Fixes: a46f8d5 ("net/failsafe: add fail-safe PMD")
> Cc: stable@dpdk.org
> Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>


Hi Gaetan,

Can you please review this patch?

Thanks,
ferruh

  reply	other threads:[~2021-11-22  9:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 11:51 [dpdk-stable] [PATCH 1/1] " vipul.ashri
2021-10-21 21:42 ` [dpdk-stable] [PATCH v2] " vipul.ashri
2021-11-22  9:36   ` Ferruh Yigit [this message]
2021-11-22 10:23   ` Gaëtan Rivet
2022-02-14 14:47     ` vipul.ashri
2022-02-15 13:07     ` vipul.ashri
2022-02-15 16:24     ` Vipul Ashri
2022-02-15 16:46       ` Vipul Ashri
2023-10-17 16:43         ` Stephen Hemminger
2024-04-12 11:27           ` Ferruh Yigit
2023-07-07  9:35       ` Ferruh Yigit
2022-02-14 13:44 ` vipul.ashri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fde70266-b79c-d64c-79ea-ab731c4cfaf4@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=grive@u256.net \
    --cc=stable@dpdk.org \
    --cc=vipul.ashri@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).