From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3786A0C50 for ; Wed, 21 Jul 2021 11:29:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5C3040E64; Wed, 21 Jul 2021 11:29:44 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0879040143; Wed, 21 Jul 2021 11:29:42 +0200 (CEST) Received: from [192.168.100.116] (unknown [37.139.99.76]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 457187F500; Wed, 21 Jul 2021 12:29:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 457187F500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1626859781; bh=LOXUiCi4EvHKSlPaCu82x2VnRBJIt36M2N3XF/R+Zo0=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=cPnaJC49lhex5Y6+qVdwqMIN8Pst8MnyrhxPB4mHJoLzPuDwYvwgsstcLJqGYX3AI 1fonEjWkff+HkmTDH3c/TObbgsY07W6RiItmNRWmiYOyyzkN0izhm6fuPH6Bs9olgY cKjFxmFWzOYWUljbHaSM0iR9XjQejp6KogaYvM3c= To: Maxime Coquelin , Chenbo Xia , Andrew Rybchenko , Konstantin Ananyev , Shahaf Shuler Cc: dev@dpdk.org, Ivan Ilchenko , stable@dpdk.org References: <20210706141407.2391177-1-andrew.rybchenko@oktetlabs.ru> <20210720075445.1146963-1-andrew.rybchenko@oktetlabs.ru> From: Andrew Rybchenko Message-ID: Date: Wed, 21 Jul 2021 12:29:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v3] net/virtio: fix Rx scatter offload X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 7/20/21 7:19 PM, Maxime Coquelin wrote: > > > On 7/20/21 9:54 AM, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> Report Rx scatter offload capability depending on VIRTIO_NET_F_MRG_RXBUF. >> >> If Rx scatter is not requested, ensure that provided Rx buffers on >> each Rx queue are big enough to fit Rx packets up to configured MTU. >> >> Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ivan Ilchenko >> Signed-off-by: Andrew Rybchenko >> Reviewed-by: Maxime Coquelin >> --- >> v3: >> - fix segfault on MTU set if an Rx queue is not setup >> >> v2: >> - do not overwrite Rx offloads when Rx scatter is added >> >> drivers/net/virtio/virtio.h | 2 + >> drivers/net/virtio/virtio_ethdev.c | 65 ++++++++++++++++++++++++++++++ >> drivers/net/virtio/virtio_ethdev.h | 5 +++ >> drivers/net/virtio/virtio_rxtx.c | 10 +++++ >> 4 files changed, 82 insertions(+) >> > > Thanks for the fix. > I see my R-by is already there, but I confirm this is good to me. It was inherited from v1, since changes from v1 to v3 are really minor fixes.