From: "Guo, Jia" <jia.guo@intel.com>
To: "Wu, Wenjun1" <wenjun1.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Zhang, Yuying" <yuying.zhang@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v1] net/e1000: fix the invalid flow control mode setting
Date: Tue, 19 Jan 2021 07:43:03 +0000 [thread overview]
Message-ID: <ff1e6f3c281a4a72b9721b43811f2162@intel.com> (raw)
In-Reply-To: <20210119065847.66043-1-wenjun1.wu@intel.com>
Hi, Wenjun
> -----Original Message-----
> From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Sent: Tuesday, January 19, 2021 2:59 PM
> To: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>
> Cc: Wu, Wenjun1 <wenjun1.wu@intel.com>; stable@dpdk.org
> Subject: [PATCH v1] net/e1000: fix the invalid flow control mode setting
>
> E1000_CTRL register should be updated according to fc_conf->mode's value.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> ---
> drivers/net/e1000/igb_ethdev.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c
> b/drivers/net/e1000/igb_ethdev.c index 647aa8d99..390737393 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -3064,6 +3064,7 @@ eth_igb_flow_ctrl_set(struct rte_eth_dev *dev,
> struct rte_eth_fc_conf *fc_conf)
> uint32_t rx_buf_size;
> uint32_t max_high_water;
> uint32_t rctl;
> + uint32_t ctrl;
>
> hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> if (fc_conf->autoneg != hw->mac.autoneg) @@ -3101,6 +3102,15
> @@ eth_igb_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf
> *fc_conf)
> rctl &= ~E1000_RCTL_PMCF;
>
> E1000_WRITE_REG(hw, E1000_RCTL, rctl);
> +
Some document for ctrl, like rctl setting, would be appreciate.
> + ctrl = E1000_READ_REG(hw, E1000_CTRL);
> + ctrl &= ~(E1000_CTRL_RFCE|E1000_CTRL_TFCE);
> + if (fc_conf->mode == RTE_FC_RX_PAUSE || fc_conf->mode
> == RTE_FC_FULL)
> + ctrl |= E1000_CTRL_RFCE;
> + if (fc_conf->mode == RTE_FC_TX_PAUSE || fc_conf->mode
> == RTE_FC_FULL)
> + ctrl |= E1000_CTRL_TFCE;
What about the case if fc_conf->mode == RTE_FC_NONE? Use a switch would be help for that?
> + E1000_WRITE_REG(hw, E1000_CTRL, ctrl);
> +
> E1000_WRITE_FLUSH(hw);
>
> return 0;
> --
> 2.25.1
next prev parent reply other threads:[~2021-01-19 7:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 6:58 Wenjun Wu
2021-01-19 7:43 ` Guo, Jia [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-20 6:53 Wenjun Wu
2021-01-20 7:18 ` Guo, Jia
2021-01-20 23:35 ` Zhang, Qi Z
2021-01-20 4:58 Wenjun Wu
2021-01-20 5:55 ` Guo, Jia
2021-01-18 7:33 Wenjun Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff1e6f3c281a4a72b9721b43811f2162@intel.com \
--to=jia.guo@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wenjun1.wu@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).