patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] examples/vm_power_manager: remove vm channel number check
@ 2021-04-21 10:45 Reshma Pattan
  2021-04-23  8:56 ` David Hunt
  0 siblings, 1 reply; 3+ messages in thread
From: Reshma Pattan @ 2021-04-21 10:45 UTC (permalink / raw)
  To: dev; +Cc: Reshma Pattan, david.hunt, stable

VM channel number should not be validated against the
host vm_power_manager coremask core indexes, as VM
cores need not to be same as host cores.
So remove this check, to allow all the vm channels
to be added successfully.

Fixes: b49c677a0d24 ("examples/vm_power: respect core mask")
Cc: david.hunt@intel.com
Cc: stable@dpdk.org

Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
 examples/vm_power_manager/channel_manager.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c
index 458e37167..fe9156785 100644
--- a/examples/vm_power_manager/channel_manager.c
+++ b/examples/vm_power_manager/channel_manager.c
@@ -454,9 +454,6 @@ add_all_channels(const char *vm_name)
 					CHANNEL_MGR_SOCKET_PATH, dir->d_name);
 			continue;
 		}
-		if (rte_lcore_index(channel_num) == -1)
-			continue;
-
 		/* if channel has not been added previously */
 		if (channel_exists(vm_info, channel_num))
 			continue;
@@ -514,9 +511,6 @@ add_channels(const char *vm_name, unsigned *channel_list,
 	}
 
 	for (i = 0; i < len_channel_list; i++) {
-		if (rte_lcore_index(i) == -1)
-			continue;
-
 		if (channel_list[i] >= RTE_MAX_LCORE) {
 			RTE_LOG(INFO, CHANNEL_MANAGER, "Channel(%u) is out of range "
 							"0...%d\n", channel_list[i],
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] examples/vm_power_manager: remove vm channel number check
  2021-04-21 10:45 [dpdk-stable] [PATCH] examples/vm_power_manager: remove vm channel number check Reshma Pattan
@ 2021-04-23  8:56 ` David Hunt
  2021-05-05 21:41   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: David Hunt @ 2021-04-23  8:56 UTC (permalink / raw)
  To: Reshma Pattan, dev; +Cc: stable


On 21/4/2021 11:45 AM, Reshma Pattan wrote:
> VM channel number should not be validated against the
> host vm_power_manager coremask core indexes, as VM
> cores need not to be same as host cores.
> So remove this check, to allow all the vm channels
> to be added successfully.
>
> Fixes: b49c677a0d24 ("examples/vm_power: respect core mask")
> Cc: david.hunt@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
>   examples/vm_power_manager/channel_manager.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c
> index 458e37167..fe9156785 100644
> --- a/examples/vm_power_manager/channel_manager.c
> +++ b/examples/vm_power_manager/channel_manager.c
> @@ -454,9 +454,6 @@ add_all_channels(const char *vm_name)
>   					CHANNEL_MGR_SOCKET_PATH, dir->d_name);
>   			continue;
>   		}
> -		if (rte_lcore_index(channel_num) == -1)
> -			continue;
> -
>   		/* if channel has not been added previously */
>   		if (channel_exists(vm_info, channel_num))
>   			continue;
> @@ -514,9 +511,6 @@ add_channels(const char *vm_name, unsigned *channel_list,
>   	}
>   
>   	for (i = 0; i < len_channel_list; i++) {
> -		if (rte_lcore_index(i) == -1)
> -			continue;
> -
>   		if (channel_list[i] >= RTE_MAX_LCORE) {
>   			RTE_LOG(INFO, CHANNEL_MANAGER, "Channel(%u) is out of range "
>   							"0...%d\n", channel_list[i],


Thanks, Reshma.

The rte_lcore_index() call was incorrectly comparing virtual core_id 
against the list of physical core_ids.

Reviewed-by: David Hunt <david.hunt@intel.com>




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/vm_power_manager: remove vm channel number check
  2021-04-23  8:56 ` David Hunt
@ 2021-05-05 21:41   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-05-05 21:41 UTC (permalink / raw)
  To: Reshma Pattan; +Cc: dev, stable, David Hunt

23/04/2021 10:56, David Hunt:
> 
> On 21/4/2021 11:45 AM, Reshma Pattan wrote:
> > VM channel number should not be validated against the
> > host vm_power_manager coremask core indexes, as VM
> > cores need not to be same as host cores.
> > So remove this check, to allow all the vm channels
> > to be added successfully.
> >
> > Fixes: b49c677a0d24 ("examples/vm_power: respect core mask")
> > Cc: david.hunt@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> 
> Thanks, Reshma.
> 
> The rte_lcore_index() call was incorrectly comparing virtual core_id 
> against the list of physical core_ids.
> 
> Reviewed-by: David Hunt <david.hunt@intel.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-05 21:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 10:45 [dpdk-stable] [PATCH] examples/vm_power_manager: remove vm channel number check Reshma Pattan
2021-04-23  8:56 ` David Hunt
2021-05-05 21:41   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git