DPDK patches and discussions
 help / color / mirror / Atom feed
From: =?gb18030?B?MTgxOTg0Njc4Nw==?= <1819846787@qq.com>
To: =?gb18030?B?RGF2aWQgTWFyY2hhbmQ=?= <david.marchand@redhat.com>
Cc: =?gb18030?B?ZGV2?= <dev@dpdk.org>,
	=?gb18030?B?Y2lhcmEucG93ZXI=?= <ciara.power@intel.com>,
	=?gb18030?B?QnJ1Y2UgUmljaGFyZHNvbg==?=
	<bruce.richardson@intel.com>
Subject: =?gb18030?B?u9i4tKO6IFtQQVRDSF0gbGliL3RlbGVtZXRyeTpmaXggdGVsZW1ldHJ5IGNvbm5zIGxlYWsgaW4gY2FzZSBvZiBzb2NrZXQgd3JpdGUgZmFpbA==?=
Date: Sat, 20 Jan 2024 12:18:38 +0800	[thread overview]
Message-ID: <tencent_C82F1243E94280DFCEDBF14A86051F7F6805@qq.com> (raw)
In-Reply-To: <CAJFAV8xS-M623YZzrdy0+AjsF8LFy8v0KzSsW96C=hxR45Wv5g@mail.gmail.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 1530 bytes --]

I have modified my&nbsp; commitlog and resubmitted the patch, but I seem to have forgotten to add a [v2] flag to the patch. Do I need to resubmit the patch again?




------------------&nbsp;ԭʼÓʼþ&nbsp;------------------
·¢¼þÈË: "David Marchand"<david.marchand@redhat.com&gt;; 
·¢ËÍʱ¼ä: 2024Äê1ÔÂ19ÈÕ(ÐÇÆÚÎå) ÍíÉÏ11:54
ÊÕ¼þÈË: " "<1819846787@qq.com&gt;; 
³­ËÍ: "dev"<dev@dpdk.org&gt;; "ciara.power"<ciara.power@intel.com&gt;; "Bruce Richardson"<bruce.richardson@intel.com&gt;; 
Ö÷Ìâ: Re: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail





On Fri, Jan 19, 2024 at 12:406§2PM sunshaowei01 <1819846787@qq.com&gt; wrote:
&gt;
&gt; Telemetry can only create 10 conns by default, each of which is processed
&gt; by a thread.
&gt;
&gt; When a thread fails to write using socket, the thread will end directly
&gt; without reducing the total number of conns.
&gt;
&gt; This will result in the machine running for a long time, and if there are
&gt; 10 failures, the telemetry will be unavailable
&gt;

Thanks for the patch, do you know which commit first triggered the issue?
This is needed so we add a Fixes: tag in the commitlog for backporting
the fix in stable releases.
See https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-related-issues

&gt; Signed-off-by: sunshaowei01 <1819846787@qq.com&gt;

We need your full name in the SoB tag.
Like, for example in my case, it would be David Marchand
<david.marchand@redhat.com&gt;.


-- 
David Marchand

[-- Attachment #2: Type: text/html, Size: 2515 bytes --]

  reply	other threads:[~2024-01-20  4:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19 11:40 [PATCH] lib/telemetry:fix telemetry conns leak in case of socket write fail sunshaowei01
2024-01-19 11:54 ` Bruce Richardson
2024-01-19 15:42 ` Power, Ciara
2024-01-19 15:54 ` David Marchand
2024-01-20  4:18   ` =?gb18030?B?MTgxOTg0Njc4Nw==?= [this message]
2024-01-22  9:05     ` 回复: " Bruce Richardson
2024-01-20  8:58 ` [PATCH] [v2]lib/telemetry:fix " Shaowei Sun
2024-01-22  7:39   ` fengchengwen
2024-01-30  1:57 ` [PATCH] [v3]lib/telemetry:fix " Shaowei Sun
2024-02-01 13:14   ` David Marchand
2024-02-01 14:11     ` =?gb18030?B?u9i4tKO6IFtQQVRDSF0gW3YzXWxpYi90ZWxlbWV0cnk6Zml4IHRlbGVtZXRyeSBjb25ucyBsZWFrIGluIGNhc2Ugb2Ygc29ja2V0IHdyaXRlIGZhaWw=?= =?gb18030?B?IFNoYW9XZWkgU3Vu?=
2024-02-01 15:19   ` [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket write fail David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_C82F1243E94280DFCEDBF14A86051F7F6805@qq.com \
    --to=1819846787@qq.com \
    --cc=bruce.richardson@intel.com \
    --cc=ciara.power@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).