From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Rosen Xu <rosen.xu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw51914 [PATCH v2 03/15] drivers/net/ipn3ke: add IPN3KE ethdev PMD driver
Date: Fri, 29 Mar 2019 17:00:44 +0100 (CET) [thread overview]
Message-ID: <20190329160044.810675B16@dpdk.org> (raw)
In-Reply-To: <1553875099-166351-4-git-send-email-rosen.xu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/51914
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW'
#580: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:259:
+ if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+ (afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH'
#580: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:259:
+ if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+ (afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW'
#649: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:328:
+ if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+ (afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH'
#649: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:328:
+ if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+ (afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#653: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:332:
+
+ }
CHECK:BRACES: braces {} should be used on all arms of this statement
#717: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:396:
+ if (!afu_dev->shared.data) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#732: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:411:
+ } else
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#741: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:420:
+ for (i = 0; i < hw->port_num; i++) {
+
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#746: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:425:
+
+ }
CHECK:BRACES: braces {} should be used on all arms of this statement
#911: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:590:
+ if (rte_kvargs_process(kvlist, IPN3KE_AFU_NAME,
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#917: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:596:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#922: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:601:
+ if (rte_kvargs_process(kvlist, IPN3KE_FPGA_ACCELERATION_LIST,
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#928: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:607:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#933: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:612:
+ if (rte_kvargs_process(kvlist, IPN3KE_I40E_PF_LIST,
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#939: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:618:
+ } else
CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#1173: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.h:131:
+#define IPN3KE_TM_COS_NODE_NUM (64*1024)
^
CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#1174: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.h:132:
+#define IPN3KE_TM_VT_NODE_NUM (IPN3KE_TM_COS_NODE_NUM/8)
^
CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#1181: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.h:139:
+#define IPN3KE_TM_TDROP_PROFILE_NUM (2*1024)
^
total: 0 errors, 0 warnings, 1963 lines checked
parent reply other threads:[~2019-03-29 16:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1553875099-166351-4-git-send-email-rosen.xu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329160044.810675B16@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=rosen.xu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).