From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 021CBA05D3
	for <public@inbox.dpdk.org>; Fri, 29 Mar 2019 17:01:13 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A9B885F16;
	Fri, 29 Mar 2019 17:01:12 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id 810675B16; Fri, 29 Mar 2019 17:00:44 +0100 (CET)
In-Reply-To: <1553875099-166351-4-git-send-email-rosen.xu@intel.com>
References: <1553875099-166351-4-git-send-email-rosen.xu@intel.com>
To: test-report@dpdk.org
Cc: Rosen Xu <rosen.xu@intel.com>
Message-Id: <20190329160044.810675B16@dpdk.org>
Date: Fri, 29 Mar 2019 17:00:44 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw51914 [PATCH v2 03/15]
	drivers/net/ipn3ke: add IPN3KE ethdev PMD driver
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/51914

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW'
#580: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:259:
+	if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+		(afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH'
#580: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:259:
+	if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+		(afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW'
#649: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:328:
+	if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+		(afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH'
#649: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:328:
+	if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+		(afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#653: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:332:
+
+	}

CHECK:BRACES: braces {} should be used on all arms of this statement
#717: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:396:
+	if (!afu_dev->shared.data) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#732: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:411:
+	} else

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#741: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:420:
+	for (i = 0; i < hw->port_num; i++) {
+

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#746: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:425:
+
+	}

CHECK:BRACES: braces {} should be used on all arms of this statement
#911: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:590:
+		if (rte_kvargs_process(kvlist, IPN3KE_AFU_NAME,
[...]
+		} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#917: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:596:
+		} else

CHECK:BRACES: braces {} should be used on all arms of this statement
#922: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:601:
+		if (rte_kvargs_process(kvlist, IPN3KE_FPGA_ACCELERATION_LIST,
[...]
+		} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#928: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:607:
+		} else

CHECK:BRACES: braces {} should be used on all arms of this statement
#933: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:612:
+		if (rte_kvargs_process(kvlist, IPN3KE_I40E_PF_LIST,
[...]
+		} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#939: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:618:
+		} else

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#1173: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.h:131:
+#define IPN3KE_TM_COS_NODE_NUM      (64*1024)
                                        ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#1174: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.h:132:
+#define IPN3KE_TM_VT_NODE_NUM       (IPN3KE_TM_COS_NODE_NUM/8)
                                                            ^

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#1181: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.h:139:
+#define IPN3KE_TM_TDROP_PROFILE_NUM (2*1024)
                                       ^

total: 0 errors, 0 warnings, 1963 lines checked