From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id AAD04A0679
	for <public@inbox.dpdk.org>; Tue,  2 Apr 2019 15:57:56 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 9C4654C99;
	Tue,  2 Apr 2019 15:57:56 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 5C15F5688; Tue,  2 Apr 2019 15:57:54 +0200 (CEST)
In-Reply-To: <1554213434-60684-4-git-send-email-rosen.xu@intel.com>
References: <1554213434-60684-4-git-send-email-rosen.xu@intel.com>
To: test-report@dpdk.org
Cc: "Xu, Rosen" <rosen.xu@intel.com>
Message-Id: <20190402135754.5C15F5688@dpdk.org>
Date: Tue,  2 Apr 2019 15:57:54 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw52099 [PATCH v3 03/14]
	drivers/net/ipn3ke: add IPN3KE ethdev PMD driver
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52099

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW'
#569: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:246:
+	if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+		(afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH'
#569: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:246:
+	if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+		(afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW'
#638: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:315:
+	if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+		(afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH'
#638: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:315:
+	if ((afu_dev->id.uuid.uuid_low == IPN3KE_UUID_VBNG_LOW) &&
+		(afu_dev->id.uuid.uuid_high == IPN3KE_UUID_VBNG_HIGH)) {

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#642: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:319:
+
+	}

CHECK:BRACES: braces {} should be used on all arms of this statement
#706: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:383:
+	if (!afu_dev->shared.data) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#721: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:398:
+	} else

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#730: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:407:
+	for (i = 0; i < hw->port_num; i++) {
+

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#735: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:412:
+
+	}

CHECK:BRACES: braces {} should be used on all arms of this statement
#900: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:577:
+		if (rte_kvargs_process(kvlist, IPN3KE_AFU_NAME,
[...]
+		} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#906: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:583:
+		} else

CHECK:BRACES: braces {} should be used on all arms of this statement
#911: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:588:
+		if (rte_kvargs_process(kvlist, IPN3KE_FPGA_ACCELERATION_LIST,
[...]
+		} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#917: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:594:
+		} else

CHECK:BRACES: braces {} should be used on all arms of this statement
#922: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:599:
+		if (rte_kvargs_process(kvlist, IPN3KE_I40E_PF_LIST,
[...]
+		} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#928: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.c:605:
+		} else

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#1166: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.h:131:
+#define IPN3KE_TM_COS_NODE_NUM      (64*1024)
                                        ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#1167: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.h:132:
+#define IPN3KE_TM_VT_NODE_NUM       (IPN3KE_TM_COS_NODE_NUM/8)
                                                            ^

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#1174: FILE: drivers/net/ipn3ke/ipn3ke_ethdev.h:139:
+#define IPN3KE_TM_TDROP_PROFILE_NUM (2*1024)
                                       ^

total: 0 errors, 0 warnings, 1955 lines checked